D27700: Add an autotest for ActionToolBar
This revision was automatically updated to reflect the committed changes. Closed by commit R169:fd0f3ea202f3: Add an autotest for ActionToolBar (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27700?vs=76556&id=76820 REVISION DETAIL https://phabricator.kde.org/D27700 AFFECTED FILES autotests/CMakeLists.txt autotests/tst_actiontoolbar.qml src/CMakeLists.txt To: ahiemstra, #kirigami, mart Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, ahiemstra, davidedmundson, mart, hein
D27700: Add an autotest for ActionToolBar
ahiemstra added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:86 > Maybe pass different COMMAND to the same add_custom_command? As is it reads > like you're declaring the command several times. > > See https://cmake.org/cmake/help/v3.13/command/add_custom_command.html Good point. Done. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27700 To: ahiemstra, #kirigami Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, ahiemstra, davidedmundson, mart, hein
D27700: Add an autotest for ActionToolBar
ahiemstra updated this revision to Diff 76556. ahiemstra added a comment. - Don't use multiple commands to achieve what one can also do REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27700?vs=76539&id=76556 BRANCH actiontoolbar_test REVISION DETAIL https://phabricator.kde.org/D27700 AFFECTED FILES autotests/CMakeLists.txt autotests/tst_actiontoolbar.qml src/CMakeLists.txt To: ahiemstra, #kirigami Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, ahiemstra, davidedmundson, mart, hein
