D27701: [ComboBox] Use transparent dimmer

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:2c777b1b4661: [ComboBox] Use transparent dimmer (authored 
by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27701?vs=76546&id=80072#toc

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27701?vs=76546&id=80072

REVISION DETAIL
  https://phabricator.kde.org/D27701

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: broulik, #plasma, ngraham, mart
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27701: [ComboBox] Use transparent dimmer

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yeah, this fixes those issues for me too. Seems to make sense.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27701

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27701: [ComboBox] Use transparent dimmer

[Kai Uwe Broulik]

broulik added a comment.


  Affects any `ComboBox` in a KCM for me, that isn't in a `Popup`: Fonts KCM, 
GTK config on Styles KCM (not the one in the fine tuning popup), the filter in 
colors KCM, ...

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27701

To: broulik, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27701: [ComboBox] Use transparent dimmer

[Nathaniel Graham]

ngraham added a comment.


  Ah yes, can reproduce with that combobox, when running the KScreen KCM in 
both System Settings and KCMShell. But not for other comboboxes! :p

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27701

To: broulik, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27701: [ComboBox] Use transparent dimmer

[Kai Uwe Broulik]

broulik added a comment.


  In D27701#628321 , @ngraham wrote:
  
  > I can't reproduce the issue with the comboboxes on the system tray settings 
page, which are in a scrollview. Where can I see the original bug?
  
  
  e.g. KScreen's resolution ComboBox
  
  Yeah, doesn't seem to be ScrollView's fault. I haven't figured out yet why it 
is. I suspect something with `QQuickWidget` used in SystemSettings.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27701

To: broulik, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27701: [ComboBox] Use transparent dimmer

[Nathaniel Graham]

ngraham added a comment.


  I can't reproduce the issue with the comboboxes on the system tray settings 
page, which are in a scrollview. Where can I see the original bug?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27701

To: broulik, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27701: [ComboBox] Use transparent dimmer

[Kai Uwe Broulik]

broulik updated this revision to Diff 76546.
broulik edited the test plan for this revision.
broulik added a comment.


  - Clarify comment

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27701?vs=76545&id=76546

REVISION DETAIL
  https://phabricator.kde.org/D27701

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27701: [ComboBox] Use transparent dimmer

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When not using `dim` it breaks "click outside" for `ComboBox` when in a 
`ScrollView`.
  I believe because without an actual `Item` the `Popup` filters some events 
and might have them stolen by the `Flickable`?
  So we keep `dim` on but use a transparent `Item` to avoid it actually dimming 
its surroundings.

TEST PLAN
  - Kirigami gallery `ComboBox` still doesn't dim (it does without the `Item`)
  - `ComboBox` in QtQuick KCMs like KScreen KCM now close properly on click 
outside

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27701

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart