D27770: HiDPI improvement of left panel

[Yunhe Guo]

guoyunhe abandoned this revision.
guoyunhe marked an inline comment as done.
guoyunhe added a comment.


  I think there can be better solution. Use Breeze icons in the left panel 
instead of rendering the emoji.
  
  Reference design in Telegram Desktop:
  
  F8145244: image.png 
  
  In WhatsApp:
  
  F8145247: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27770

To: guoyunhe, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27770: HiDPI improvement of left panel

[David Edmundson]

davidedmundson added a comment.


  Is that diff up to date?
  
  Phab only shows me a QRect changing to a QRectF

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27770

To: guoyunhe, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27770: HiDPI improvement of left panel

[Yunhe Guo]

guoyunhe marked an inline comment as done.
guoyunhe added inline comments.

INLINE COMMENTS

> davidedmundson wrote in emojier.cpp:83
> this is broken

Reverted

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27770

To: guoyunhe, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27770: HiDPI improvement of left panel

[Yunhe Guo]

guoyunhe updated this revision to Diff 76758.
guoyunhe added a comment.


  Fix size

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27770?vs=76741=76758

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27770

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/emojier.cpp

To: guoyunhe, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27770: HiDPI improvement of left panel

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> emojier.cpp:83
>  if (_size) {
>  *_size = size;
>  }

this is broken

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27770

To: guoyunhe, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27770: HiDPI improvement of left panel

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27770

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/emojier.cpp

To: guoyunhe
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart