D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

[Michail Vourlakos]

mvourlakos added a comment.


  no prob, take your time...

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D27939

To: mbehrendt, mvourlakos
Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, 
jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, niccolove, ragreen, lavender, 
ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

[Marcus Behrendt]

mbehrendt added a comment.


  Okay. I just tested with other themes. 
  Was so used to Materia that I forgot about them.
  Yeah an option would make sense then. 
  I'd like to look into this but that will probably take some time.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D27939

To: mbehrendt, mvourlakos
Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, 
jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, niccolove, ragreen, lavender, 
ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

[Michail Vourlakos]

mvourlakos added a comment.


  The gap you see comes from the specific plasma theme, so this is plasma theme 
responsibility. That specific theme probably has that gap in its tasks svg.
  
  Having an option means that the user can always disable/enable that specific 
functionality if a plasma theme breaks the experience.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D27939

To: mbehrendt, mvourlakos
Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, 
jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, niccolove, ragreen, lavender, 
ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

[Marcus Behrendt]

mbehrendt added a comment.


  In D27939#624440 , @mvourlakos 
wrote:
  
  > I think it is better to have an option for this in order to not be applied 
always when the user reverses the indicator..
  >
  > And also are you sure that this way the growing circle animation of the 
indicator is still working correctly?
  
  
  I am not sure if an option makes sense here as the group triangle looks kind 
of broken when reversed
  F8167640: 2020-03-09_17-24.png 
  
  Circle animation still works
  F8167643: circle.flv 

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D27939

To: mbehrendt, mvourlakos
Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, 
jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, niccolove, ragreen, lavender, 
ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

[Michail Vourlakos]

mvourlakos added a comment.


  I think it is better to have an option for this in order to not be applied 
always when the user reverses the indicator..
  
  And also are you sure that this way the growing circle animation of the 
indicator is still working correctly?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D27939

To: mbehrendt, mvourlakos
Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, 
jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, niccolove, ragreen, lavender, 
ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

[Marcus Behrendt]

mbehrendt created this revision.
mbehrendt added a reviewer: mvourlakos.
mbehrendt added a project: Latte Dock.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mbehrendt requested review of this revision.

REVISION SUMMARY
  The triangle indicating window grouping would not move to the other side.
  Like for the BackLayer this is done for the corresponding part of the 
FrontLayer

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D27939

AFFECTED FILES
  indicators/org.kde.latte.plasma/package/ui/FrontLayer.qml

To: mbehrendt, mvourlakos
Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, 
jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, niccolove, ragreen, lavender, 
ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart