D27944: KCM Colors fix apply button always disabled

2020-03-19 Thread Cyril Rossi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4d33b8276e00: KCM Colors fix apply button always disabled 
(authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27944?vs=77282&id=77980

REVISION DETAIL
  https://phabricator.kde.org/D27944

AFFECTED FILES
  kcms/colors/colors.cpp

To: crossi, #plasma, ervin, bport, meven, broulik
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27944: KCM Colors fix apply button always disabled

2020-03-16 Thread David Edmundson 
davidedmundson added a comment.


  Apparently my patch doesn't work, so go ahead.
  
  Though I don't fully understand why my patch isn't enough

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27944

To: crossi, #plasma, ervin, bport, meven, broulik
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27944: KCM Colors fix apply button always disabled

2020-03-16 Thread Kevin Ottens 
ervin added a comment.


  I marked it accepted, but of course this is assuming David's patch wouldn't 
make it quickly and we'd need the fix here ASAP.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27944

To: crossi, #plasma, ervin, bport, meven, broulik
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27944: KCM Colors fix apply button always disabled

2020-03-09 Thread David Edmundson 
davidedmundson added a comment.


  Please see D27724 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27944

To: crossi, #plasma, ervin, bport, meven, broulik
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27944: KCM Colors fix apply button always disabled

2020-03-09 Thread Cyril Rossi 
crossi created this revision.
crossi added reviewers: Plasma, ervin, bport, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  BUG: 418604

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27944

AFFECTED FILES
  kcms/colors/colors.cpp

To: crossi, #plasma, ervin, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart