D28027: fix line rating for new format when function name is missing

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:113b91bfee13: fix line rating for new format when 
function name is missing (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28027?vs=77562=79481

REVISION DETAIL
  https://phabricator.kde.org/D28027

AFFECTED FILES
  src/parser/backtraceparsergdb.cpp
  src/tests/gdbbacktracelinetest.cpp

To: sitter, cfeck, ngraham
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28027: fix line rating for new format when function name is missing

[Ahmad Samir]

ahmadsamir added a comment.


  In D28027#630512 , @sitter wrote:
  
  > D28026 
  
  
  Ah, yes, that's where those "packagekit" lines are. Thanks :)

REPOSITORY
  R871 DrKonqi

BRANCH
  parse-rate

REVISION DETAIL
  https://phabricator.kde.org/D28027

To: sitter, cfeck, ngraham
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28027: fix line rating for new format when function name is missing

[Harald Sitter]

sitter added a comment.


  D28026 

REPOSITORY
  R871 DrKonqi

BRANCH
  parse-rate

REVISION DETAIL
  https://phabricator.kde.org/D28027

To: sitter, cfeck, ngraham
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28027: fix line rating for new format when function name is missing

[Ahmad Samir]

ahmadsamir added a comment.


  This doesn't apply cleanly.

REPOSITORY
  R871 DrKonqi

BRANCH
  parse-rate

REVISION DETAIL
  https://phabricator.kde.org/D28027

To: sitter, cfeck, ngraham
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28027: fix line rating for new format when function name is missing

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  previously this supposedly was
  
  `#2  0x7fefe9ef79e8 in ?? () at /usr/lib/dri/i965_dri.so`
  
  nowadays the ?? is simply empty. the rating mechanism wasn't properly
  handling this. treat an empty function name to mean the same as ?? and
  rate the line as MissingFunction/Everything depending on whether
  libraryName is also missing.
  
  also update test expectations accordingly (could have actually seen that
  discrepancy if one had paid attention to the outcoming rating :S)
  
  CCBUG: 418538

TEST PLAN
  test passes. most lines from 417435 now rate `MissingFunction` and the whole 
trace is considered useless
  
Rating: 128 out of 364 Usefulness: Useless
90%: 327.6 70%: 254.8 40%: 145.6

REPOSITORY
  R871 DrKonqi

BRANCH
  parse-rate

REVISION DETAIL
  https://phabricator.kde.org/D28027

AFFECTED FILES
  src/parser/backtraceparsergdb.cpp
  src/tests/gdbbacktracelinetest.cpp

To: sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart