D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

[Bhushan Shah]

bshah updated this revision to Diff 77896.
bshah added a comment.


  - rename method to lock rotation
  - disconnect/connect orientation sensor when we want to lock/unlock rotation

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28115?vs=77879&id=77896

BRANCH
  arcpatch-D28115

REVISION DETAIL
  https://phabricator.kde.org/D28115

AFFECTED FILES
  kded/config.cpp
  kded/config.h
  kded/daemon.cpp
  kded/daemon.h
  kded/org.kde.KScreen.xml

To: bshah, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

[Roman Gilg]

romangg added a comment.


  So I think of two things to consider:
  
  - How is the overall interaction? Do we want something in line with other 
systems? Then we should have a lock/unlock rotation workflow where the current 
rotation orientation is made permanent until the icon is tapped again. Android 
 and GNOME 

 do it like this.
  - To make this consistent with the KScreen KCM the values should be written 
to the control file. I.e. your `KScreenDaemon::setAutoRotation` method should 
call into `ControlConfig::setAutoRotate`. Then it would just change for example 
when you lock the rotation from auto to manual and the current rotation value 
is set anyway.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28115

To: bshah, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

[Bhushan Shah]

bshah added a comment.


  Maybe it would be sensible idea to instead connect/disconnect orientation 
sensor, and replace method name with "inhibitAutoRotation"?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28115

To: bshah, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

[Bhushan Shah]

bshah updated this revision to Diff 77879.
bshah added a comment.


  update branch

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28115?vs=77878&id=77879

BRANCH
  arcpatch-D28115

REVISION DETAIL
  https://phabricator.kde.org/D28115

AFFECTED FILES
  kded/config.cpp
  kded/config.h
  kded/daemon.cpp
  kded/daemon.h
  kded/org.kde.KScreen.xml

To: bshah, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

[Bhushan Shah]

bshah created this revision.
bshah added a reviewer: romangg.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  This allows to toggle the auto-rotation or temporary inhibit it on
  mobile.

TEST PLAN
  it works partially currently, after first rotation event
  it re-enables rotation somehow.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28115

AFFECTED FILES
  kded/config.cpp
  kded/config.h
  kded/daemon.cpp
  kded/daemon.h
  kded/org.kde.KScreen.xml

To: bshah, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart