D28137: make servicerunner only build once

2020-03-20 Thread Harald Sitter 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d03f98e782c3: make servicerunner only build once 
(authored by sitter).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28137?vs=77999=78076

REVISION DETAIL
  https://phabricator.kde.org/D28137

AFFECTED FILES
  runners/services/CMakeLists.txt
  runners/services/autotests/CMakeLists.txt
  runners/services/plugin.cpp
  runners/services/servicerunner.cpp

To: sitter, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28137: make servicerunner only build once

2020-03-19 Thread Harald Sitter 
sitter created this revision.
sitter added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  build the runner itself in a static lib we can use for testing and then
  link that into a module lib together with the factory entry point to
  compose the final lib for installation
  
  means servicesrunner.cpp is now only built once, whereas before it was
  built twice through 100% duplicative targets

TEST PLAN
  test still passes, installing and restarting krunner still yields working 
service searches

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28137

AFFECTED FILES
  runners/services/CMakeLists.txt
  runners/services/autotests/CMakeLists.txt
  runners/services/plugin.cpp
  runners/services/servicerunner.cpp

To: sitter, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart