D28138: some static analyzer improvements for service runner
This revision was automatically updated to reflect the committed changes. Closed by commit R120:fab5b5e26d7e: some static analyzer improvements for service runner (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28138?vs=78001&id=78004#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28138?vs=78001&id=78004 REVISION DETAIL https://phabricator.kde.org/D28138 AFFECTED FILES runners/services/autotests/servicerunnertest.cpp runners/services/servicerunner.cpp runners/services/servicerunner.h To: sitter, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28138: some static analyzer improvements for service runner
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> servicerunner.cpp:114
> +for(int i = 1; i < strList.size(); ++i) {
> +const auto &str = strList[i];
> if (category == QLatin1String("Name")) {
Perhaps use `.at(i)`
> servicerunner.cpp:464
>
> -QMimeData *data = new QMimeData();
> +auto data = new QMimeData();
> data->setUrls(QList{QUrl::fromLocalFile(path)});
Keep the `*` :p
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28138
To: sitter, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28138: some static analyzer improvements for service runner
sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY - be more consty (and don't risk detatching containers) - init members - don't ql1s to qstring - use auto when newing an object TEST PLAN test passes REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28138 AFFECTED FILES runners/services/autotests/servicerunnertest.cpp runners/services/servicerunner.cpp runners/services/servicerunner.h To: sitter, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
