D28277: [UrlButton] Disable when there is no URL

2020-03-26 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:d6cfab5bec74: [UrlButton] Disable when there is no URL 
(authored by broulik).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28277?vs=78460&id=78538

REVISION DETAIL
  https://phabricator.kde.org/D28277

AFFECTED FILES
  src/controls/UrlButton.qml

To: broulik, mart, #vdg, #kirigami, ngraham, apol
Cc: bugseforuns, apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ahiemstra, davidedmundson, mart

D28277: [UrlButton] Disable when there is no URL

2020-03-26 Thread Patrick Silva 
bugseforuns added a comment.


  This patch fixes bug 418580 .

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28277

To: broulik, mart, #vdg, #kirigami, ngraham, apol
Cc: bugseforuns, apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ahiemstra, davidedmundson, mart

D28277: [UrlButton] Disable when there is no URL

2020-03-25 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28277

To: broulik, mart, #vdg, #kirigami, ngraham
Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart

D28277: [UrlButton] Disable when there is no URL

2020-03-25 Thread Kai Uwe Broulik 
broulik updated this revision to Diff 78460.
broulik retitled this revision from "[UrlButton] Don't show tooltip if it would 
be empty" to "[UrlButton] Disable when there is no URL".
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - Disable completely

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28277?vs=78448&id=78460

REVISION DETAIL
  https://phabricator.kde.org/D28277

AFFECTED FILES
  src/controls/UrlButton.qml

To: broulik, mart, #vdg, #kirigami
Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart