D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

2020-04-22 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:20f451125ce7: KCM/GlobalShortut: convert FOREACH and old 
signal syntax (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28282?vs=80616=80846

REVISION DETAIL
  https://phabricator.kde.org/D28282

AFFECTED FILES
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/globalshortcuts.cpp
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/select_scheme_dialog.cpp

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

2020-04-20 Thread Méven Car 
meven updated this revision to Diff 80616.
meven added a comment.


  Fix for loop

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28282?vs=80614=80616

BRANCH
  arcpatch-D28282

REVISION DETAIL
  https://phabricator.kde.org/D28282

AFFECTED FILES
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/globalshortcuts.cpp
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/select_scheme_dialog.cpp

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

2020-04-20 Thread Méven Car 
meven updated this revision to Diff 80614.
meven added a comment.


  Rebasing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28282?vs=78913=80614

BRANCH
  arcpatch-D28282

REVISION DETAIL
  https://phabricator.kde.org/D28282

AFFECTED FILES
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/globalshortcuts.cpp
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/select_scheme_dialog.cpp

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

2020-03-30 Thread Méven Car 
meven updated this revision to Diff 78913.
meven marked 5 inline comments as done.
meven added a comment.


  Adress review (formatting) and fix a couple of indentation issues

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28282?vs=78522=78913

BRANCH
  shortcuts

REVISION DETAIL
  https://phabricator.kde.org/D28282

AFFECTED FILES
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/globalshortcuts.cpp
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/select_scheme_dialog.cpp

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

2020-03-30 Thread Benjamin Port 
bport added a comment.


  Some coding style nitpicking

INLINE COMMENTS

> export_scheme_dialog.cpp:46
>  int item=0;
> -Q_FOREACH(QString component, mComponents)
> +for (const QString  : qAsConst(mComponents))
>  {

{ on same line

> export_scheme_dialog.cpp:74
> +const auto buttons = mButtons.buttons();
> +for (const QAbstractButton *button : buttons)
>  {

{ on same line

> kglobalshortcutseditor.cpp:168
>  
> -for( KServiceGroup::List::ConstIterator it = list.constBegin();
> +for ( KServiceGroup::List::ConstIterator it = list.constBegin();
>   it != list.constEnd(); ++it) {

you have an unneeded space after (

> kglobalshortcutseditor.cpp:543
> +for (const QString  : groupList)
>  {
>  // do not overwrite the Settings group. That makes it possible to

{ on same line

> kglobalshortcutseditor.cpp:832
> +for (const QString  : keys)
>  {
>  if (components.value(text)->uniqueName() == componentUnique)

{ same line

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28282

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

2020-03-26 Thread Méven Car 
meven updated this revision to Diff 78522.
meven marked 4 inline comments as done.
meven added a comment.


  Review comments, code formating more const

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28282?vs=78457=78522

BRANCH
  shortcuts

REVISION DETAIL
  https://phabricator.kde.org/D28282

AFFECTED FILES
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/globalshortcuts.cpp
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/select_scheme_dialog.cpp

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

2020-03-26 Thread Ahmad Samir 
ahmadsamir added inline comments.

INLINE COMMENTS

> export_scheme_dialog.cpp:46
>  int item=0;
> -Q_FOREACH(QString component, mComponents)
> +for(QString component : qAsConst(mComponents))
>  {

const QString &

> export_scheme_dialog.cpp:74
> +const auto buttons = mButtons.buttons();
> +for(QAbstractButton const *button : buttons)
>  {

const QAbstractButton *button

> kglobalshortcutseditor.cpp:708
>  {
> -Q_FOREACH (ComponentData *cd, d->components) {
> +for (ComponentData *cd : qAsConst(d->components)) {
>  if (cd->editor()->isModified()) {

I would make the ComponentData::editor() method const, then 'const 
ComponentData *cd'.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28282

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

2020-03-25 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> globalshortcuts.cpp:42
>  editor = new KGlobalShortcutsEditor(this, 
> KShortcutsEditor::GlobalAction);
> -connect(editor, SIGNAL(changed(bool)), this, SIGNAL(changed(bool)));
> +connect(editor, ::changed, this, 
> QOverload::of(::changed));
>  

Use markAsChanged then you don't need to overload.

> kglobalshortcutseditor.h:84
>   */
> -void exportConfiguration(QStringList componentsFriendly, KConfig 
> *config) const;
> +void exportConfiguration(const QStringList componentsFriendly, KConfig 
> *config) const;
>  

why not const QStringList &

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28282

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

2020-03-25 Thread Méven Car 
meven created this revision.
meven added reviewers: ervin, bport, crossi, hchain, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

TEST PLAN
  Builds, changed a shortcut and back again

REPOSITORY
  R119 Plasma Desktop

BRANCH
  shortcuts

REVISION DETAIL
  https://phabricator.kde.org/D28282

AFFECTED FILES
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/globalshortcuts.cpp
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/select_scheme_dialog.cpp

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart