D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry
This revision was automatically updated to reflect the committed changes. Closed by commit R120:fede85a3d0ea: [applets/systemtray] Clear item from shown/hidden list when disabling entry (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28311?vs=78561&id=78563#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28311?vs=78561&id=78563 REVISION DETAIL https://phabricator.kde.org/D28311 AFFECTED FILES applets/systemtray/package/contents/ui/ConfigEntries.qml To: nicolasfella, #plasma, kmaterka, broulik Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> ConfigEntries.qml:226
> case "disabled":
> if (extraIndex > -1) {
> cfg_extraItems.splice(extraIndex, 1)
Keep the order consistent with the cases above: shown, hidden, extra
REPOSITORY
R120 Plasma Workspace
BRANCH
systrayhidden
REVISION DETAIL
https://phabricator.kde.org/D28311
To: nicolasfella, #plasma, kmaterka, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry
nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Else the entry is still in cfg_shownItems/cfg_hiddenItems and the config UI will display it as shown instead of disabled. BUG: 419197 REPOSITORY R120 Plasma Workspace BRANCH systrayhidden REVISION DETAIL https://phabricator.kde.org/D28311 AFFECTED FILES applets/systemtray/package/contents/ui/ConfigEntries.qml To: nicolasfella, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
