D28576: Converted to page and added Heading

2020-04-19 Thread Niccolò Venerandi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7d0a74721c5f: Converted to page and added Heading 
(authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28576?vs=79484=80583

REVISION DETAIL
  https://phabricator.kde.org/D28576

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: niccolove, #plasma, mart
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28576: Converted to page and added Heading

2020-04-16 Thread Nathaniel Graham 
ngraham added a comment.


  Needs a rebase, but LGTM!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28576

To: niccolove, #plasma, mart
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28576: Converted to page and added Heading

2020-04-06 Thread Niccolò Venerandi 
niccolove added a comment.


  Ok, should be fine now

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28576

To: niccolove, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28576: Converted to page and added Heading

2020-04-06 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 79484.
niccolove added a comment.


  Fixed layouts

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28576?vs=79347=79484

BRANCH
  notification_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28576

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: niccolove, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28576: Converted to page and added Heading

2020-04-06 Thread Niccolò Venerandi 
niccolove added a comment.


  Yes, also the notifications don't fill width, just noticed, I'm investigating

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28576

To: niccolove, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28576: Converted to page and added Heading

2020-04-06 Thread Marco Martin 
mart added a comment.


  is the no notification message now uncentered related to this commit?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28576

To: niccolove, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28576: Converted to page and added Heading

2020-04-04 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 79347.
niccolove added a comment.


  Fixed context menu

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28576?vs=79346=79347

BRANCH
  notification_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28576

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28576: Converted to page and added Heading

2020-04-04 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  As per D28575 , converted the FullRepr to 
be a Page and added a PlasmoidHeading
  
  Result:
  
  (...)

TEST PLAN
  Test with D28575 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28576

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart