D28949: Add titlebar colors to Kirigami::PlatformTheme

2020-04-20 Thread Carson Black 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:0d5d94ebe086: Add titlebar colors to 
Kirigami::PlatformTheme (authored by cblack).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28949?vs=80476=80708

REVISION DETAIL
  https://phabricator.kde.org/D28949

AFFECTED FILES
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h

To: cblack, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D28949: Add titlebar colors to Kirigami::PlatformTheme

2020-04-20 Thread Marco Martin 
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  ok, thanks for the clarification

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/tools-area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28949

To: cblack, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D28949: Add titlebar colors to Kirigami::PlatformTheme

2020-04-20 Thread Marco Martin 
mart added a comment.


  what's the "tools area"?
  are there other use cases than client side decorations? (which we don't want 
to support)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28949

To: cblack, #kirigami
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D28949: Add titlebar colors to Kirigami::PlatformTheme

2020-04-18 Thread Carson Black 
cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  This is a prerequisite for implementing the tools area in QML applications, 
which requires having access to the titlbar colour.

TEST PLAN
import QtQuick 2.0
import org.kde.kirigami 2.12 as Kirigami

Rectangle {
color: Kirigami.Theme.titlebarBackgroundColor
}

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/tools-area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28949

AFFECTED FILES
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h

To: cblack, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart