D29033: Remove duplicated code

2020-04-21 Thread Aleix Pol Gonzalez 
apol abandoned this revision.
apol added a comment.


  My bad, thanks!

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29033

To: apol, #frameworks, zzag
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29033: Remove duplicated code

2020-04-21 Thread Vlad Zahorodnii 
zzag requested changes to this revision.
zzag added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> waylandintegration.cpp:191
>  [this] (PlasmaWindow *w) {
> -emit KWindowSystem::self()->windowAdded(w->internalId());
> -emit KWindowSystem::self()->stackingOrderChanged();

The old and the new code are not the same. With f(), we're going to emit 
windowRemoved() instead of windowAdded().

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29033

To: apol, #frameworks, zzag
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29033: Remove duplicated code

2020-04-20 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Went through it while reviewing some code.

TEST PLAN
  Been running it for a while, including direct testing of the code while 
investigating something else

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29033

AFFECTED FILES
  src/windowsystem/waylandintegration.cpp

To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart