D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

[Filip Fila]

filipf updated this revision to Diff 81911.
filipf added a comment.


  restore the inline message but change its text to note that layout changes 
have been restricted by the sysadmin

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29366?vs=81756=81911

BRANCH
  remove-obsolete-inline-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29366

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: filipf, #plasma
Cc: mart, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

[Marco Martin]

mart added a comment.


  In D29366#661956 , @filipf wrote:
  
  > Ok, so the message can indeed still be turned on.
  >
  > Setting:
  >  `~/.config/plasmarc [General] immutability=2 (or 4)`
  >
  > ... does not work, however the following does:
  >
  > `~/.config/kdeglobals [KDE Action Restrictions][$i] 
plasma/plasmashell/unlockedDesktop=false`
  >
  > Which means that if widget locking now only exists as a restriction... 
perhaps it would make more sense to change the text of this inline message to 
say "Layout changes have been restricted by the system administrator"?
  
  
  yeah, +1 for that

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29366

To: filipf, #plasma
Cc: mart, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

[Filip Fila]

filipf added a comment.


  Ok, so the message can indeed still be turned on.
  
  Setting:
  `~/.config/plasmarc [General] immutability=2 (or 4)`
  
  ... does not work, however the following does:
  
  `~/.config/kdeglobals [KDE Action Restrictions][$i] 
plasma/plasmashell/unlockedDesktop=false`
  
  Which means that if widget locking now only exists as a restriction... 
perhaps it would make more sense to change the text of this inline message to 
say "Layout changes have been restricted by the system administrator"?
  Otherwise telling a restricted user that widgets are locked isn't helpful 
since they can't (and shouldn't) unlock their widgets?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29366

To: filipf, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

[Nathaniel Graham]

ngraham added a comment.


  You need to set it in the config file by hand IIRC. It's quite hidden now, 
and will inevitably bit-rot. :/ I wonder if we should just bite the bullet and 
fully kill it, or expose a super hidden GUI for it somewhere,

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29366

To: filipf, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

[Filip Fila]

filipf added a comment.


  In D29366#661834 , @ngraham wrote:
  
  > Technically it still does exist, it's just hidden. If a person does enable 
this, perhaps the message is still nice to have? Or maybe we should not show it 
because the expectation would be that your admin/technically competent grandson 
has enabled it for your own good and this shouldn't be highlighted?
  
  
  Hmm if it still exists then we probably want to leave it because it doesn't 
make not being able to change the desktop layout look like a bug. How to enable 
widget locking currently though?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29366

To: filipf, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

[Nathaniel Graham]

ngraham added a comment.


  Technically it still does exist, it's just hidden. If a person does enable 
this, perhaps the message is still nice to have? Or maybe we should not show it 
because the expectation would be that your admin/technically competent grandson 
has enabled it for your own good and this shouldn't be highlighted?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29366

To: filipf, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

[Filip Fila]

filipf created this revision.
filipf added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Widget locking no longer exists so we can remove the inline message that 
warned of locked widgets.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  remove-obsolete-inline-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29366

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: filipf, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart