D29748: [GTK Integration] Deprecate GTK2 (Hide backend interface)

2020-05-31 Thread Mikhail Zolotukhin
gikari abandoned this revision.
gikari added a comment.


  See D29749 

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D29748

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29748: [GTK Integration] Deprecate GTK2 (Hide backend interface)

2020-05-14 Thread Mikhail Zolotukhin
gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Since Inkscape is finally moved to GTK3, it's time to start GTK2
  deprecation process.
  
  What this does is just a hiding direct interface for setting GTK2 themes.
  Despite of that, GTK2 will be set implicitly along with the GTK3 theme.
  
  Some FAQ:
  Q: What if there is no GTK2 theme with the name of GTK2 one?
  A: Chances of that is close to zero. Most, if not all, GTK3 themes
  contain gtk-2.0 folder along with gtk-3.0 one. Even if there is such
  a theme, currently it also will not work. That's because of xsettingsd,
  that overrides GTK2 configuration file.
  
  Q: What about Breeze Dark GTK2 theme for GIMP?
  A: GIMP has a dark theme inside. Breeze-dark will not work for the same
  reason as the above - xsettingsd with only one theme for GTK2 and GTK3.

TEST PLAN
  See KCM revision

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  hide-gtk2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29748

AFFECTED FILES
  CMakeLists.txt
  gtkproxies/CMakeLists.txt
  gtkproxies/preview.c
  gtkproxies/preview.ui
  gtkproxies/reload.c
  kconf_update/gtktheme.cpp
  kded/configeditor.cpp
  kded/configeditor.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/themepreviewer.cpp
  kded/themepreviewer.h

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart