D3650: lower mouse acceleration limit to 0.0
graesslin added a comment. In https://phabricator.kde.org/D3650#112888, @apol wrote: > In https://phabricator.kde.org/D3650#80584, @graesslin wrote: > > > According to my comments in the Wayland port: the value 1.0 means no acceleration. Values below 1.0 mean a de-acceleration or a slow down. But it's still a factor. I'm also afraid that putting a 0.0 there could result in a devision by 0 value. > > > > So in any case your commit message does not match the actual reality. And given that I think you are trying to fix the wrong problem. Might it be that you use the libinput xorg driver? If yes, that's not yet supported and needs porting. But this change has potential of breaking the non-libinput xorg driver then. > > > > From my side something between -1 and -2 for this change. > > > Does this mean that 0.0 means not moving at all? That doesn't sound right. It could mean a crash in X - division by zero. No idea how X handles the situation, but 0 is clearly a wrong value here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3650 To: sitter, plasma-devel Cc: apol, graesslin, broulik, jensreuterberg, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, abetts, sebas, mart, lukas
D3650: lower mouse acceleration limit to 0.0
apol added a comment. In https://phabricator.kde.org/D3650#80584, @graesslin wrote: > According to my comments in the Wayland port: the value 1.0 means no acceleration. Values below 1.0 mean a de-acceleration or a slow down. But it's still a factor. I'm also afraid that putting a 0.0 there could result in a devision by 0 value. > > So in any case your commit message does not match the actual reality. And given that I think you are trying to fix the wrong problem. Might it be that you use the libinput xorg driver? If yes, that's not yet supported and needs porting. But this change has potential of breaking the non-libinput xorg driver then. > > From my side something between -1 and -2 for this change. Does this mean that 0.0 means not moving at all? That doesn't sound right. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3650 To: sitter, plasma-devel Cc: apol, graesslin, broulik, jensreuterberg, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, abetts, sebas, mart, lukas
D3650: lower mouse acceleration limit to 0.0
jensreuterberg added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3650 To: sitter, plasma-devel Cc: graesslin, broulik, jensreuterberg, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, abetts, sebas, apol, mart, lukas
[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0
sitter added a comment. That's not really answering my question now is it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3650 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, plasma-devel Cc: graesslin, broulik, jensreuterberg, lesliezhai, ali-mohamed, abetts, sebas
[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0
graesslin added a comment. According to my comments in the Wayland port: the value 1.0 means no acceleration. Values below 1.0 mean a de-acceleration or a slow down. But it's still a factor. I'm also afraid that putting a 0.0 there could result in a devision by 0 value. So in any case your commit message does not match the actual reality. And given that I think you are trying to fix the wrong problem. Might it be that you use the libinput xorg driver? If yes, that's not yet supported and needs porting. But this change has potential of breaking the non-libinput xorg driver then. From my side something between -1 and -2 for this change. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3650 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, plasma-devel Cc: graesslin, broulik, jensreuterberg, lesliezhai, ali-mohamed, abetts, sebas
[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0
sitter added a comment. Do I need to do something to get this moving forward? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3650 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, plasma-devel Cc: graesslin, broulik, jensreuterberg, lesliezhai, ali-mohamed, abetts, sebas
[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0
sitter added a comment. Ok. Kindly take note of potential adjustment needs then. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3650 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, plasma-devel Cc: graesslin, broulik, jensreuterberg, lesliezhai, ali-mohamed, abetts, sebas
[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0
graesslin added a comment. In https://phabricator.kde.org/D3650#68360, @sitter wrote: > Possibly. > > The KCM does not appear to actually work on wayland though ^^ It does. I ported it and it works and adjusts the settings for Wayland if KWin is used. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3650 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, plasma-devel Cc: graesslin, broulik, jensreuterberg, lesliezhai, ali-mohamed, abetts, sebas
[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0
sitter added a comment.
Possibly.
The KCM does not appear to actually work on wayland though ^^
if (!QX11Info::isPlatformX11()) {
return;
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3650
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sitter, plasma-devel
Cc: broulik, jensreuterberg, lesliezhai, ali-mohamed, abetts, sebas
[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0
broulik added a comment. I think KWin's Wayland input mapping logic needs to be adjusted then? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3650 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, plasma-devel Cc: broulik, jensreuterberg, lesliezhai, ali-mohamed, abetts, sebas
[Differential] [Request, 2 lines] D3650: lower mouse acceleration limit to 0.0
sitter created this revision. sitter added a reviewer: plasma-devel. sitter added a subscriber: jensreuterberg. Restricted Application added a project: Plasma. REVISION SUMMARY as seen in bug 95928 this used to be locked at 1 but was lowered to 0.1 as acceleration != speed, so <1 makes perfect sense. however, by extension, 0.0 also makes sense (no acceleration on top of hardware input) which I think was an oversight in the original decrease. this change sets the lower bounds of the input field to 0.0 so one can effectively disable acceleration CHANGELOG: Mouse settings now allow setting acceleration to 0.0 TEST PLAN - build - set acceleration to 0.0 - mouse super slow REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3650 AFFECTED FILES kcms/input/mouse.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, plasma-devel Cc: jensreuterberg, lesliezhai, ali-mohamed, abetts, sebas
