D4773: [kcheckpass] Drop the caller command line option

2017-03-08 Thread Martin Gräßlin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:cbc60df2ed07: [kcheckpass] Drop the caller command line 
option (authored by graesslin).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4773?vs=11789&id=12300

REVISION DETAIL
  https://phabricator.kde.org/D4773

AFFECTED FILES
  greeter/autotests/fakekcheckpass.c
  kcheckpass/checkpass_pam.c
  kcheckpass/kcheckpass.c
  kcheckpass/kcheckpass.h

To: graesslin, #plasma, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D4773: [kcheckpass] Drop the caller command line option

2017-03-08 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

BRANCH
  drop-caller

REVISION DETAIL
  https://phabricator.kde.org/D4773

To: graesslin, #plasma, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D4773: [kcheckpass] Drop the caller command line option

2017-03-07 Thread Martin Gräßlin 
graesslin added a comment.


  ping

REVISION DETAIL
  https://phabricator.kde.org/D4773

To: graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Updated] D4773: [kcheckpass] Drop the caller command line option

2017-02-24 Thread Martin Gräßlin 
graesslin added a dependent revision: D4780: [kcheckpass] Drop the conv_legacy 
support.

REVISION DETAIL
  https://phabricator.kde.org/D4773

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 36 lines] D4773: [kcheckpass] Drop the caller command line option

2017-02-24 Thread Martin Gräßlin 
graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This was used to the specify calling application, effectively the
  PAM service basename. As the greeter doesn't set it, it is unused
  and unknown whether that would work at all.
  
  By dropping the option we can significantly reduce the ifdef mess
  by having the same argument count for all auth backends again.

BRANCH
  drop-caller

REVISION DETAIL
  https://phabricator.kde.org/D4773

AFFECTED FILES
  greeter/autotests/fakekcheckpass.c
  kcheckpass/checkpass_pam.c
  kcheckpass/kcheckpass.c
  kcheckpass/kcheckpass.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Updated] D4773: [kcheckpass] Drop the caller command line option

2017-02-24 Thread Martin Gräßlin 
graesslin added a dependency: D4759: [kcheckpass] Drop command line option for 
username.

REVISION DETAIL
  https://phabricator.kde.org/D4773

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol