D5114: support for high dpi in aurorae

2017-06-05 Thread David Edmundson 
davidedmundson added a comment.


  > bonus points if the dpi is calculated as mean of dpiX and dpiY.
  
  Maybe, but it's more important that it matches what frameSvg is doing which 
is currently :src/declarativeimports/core/units.cpp:const qreal dpi = 
primary->logicalDotsPerInchX();
  If it's set via Xft DPI override, it's set squarely anyway.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5114

To: mart, #plasma, graesslin
Cc: davidedmundson, rikmills, luebking, plasma-devel, kwin, #kwin, ZrenBot, 
spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, 
sebas, apol, mart, lukas

D5114: support for high dpi in aurorae

2017-06-04 Thread Rik Mills 
rikmills added a comment.


  In https://phabricator.kde.org/D5114#113943, @luebking wrote:
  
  > Just saw this because of a bug report.
  
  
  This one I presume: https://bugs.kde.org/show_bug.cgi?id=380524
  
  The bug affects me on 5.10 (I am comment #1)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5114

To: mart, #plasma, graesslin
Cc: rikmills, luebking, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D5114: support for high dpi in aurorae

2017-06-04 Thread Thomas Lübking 
luebking added a comment.


  Just saw this because of a bug report.
  Why was this patch approved at all?
  
  This line:
  
scaleFactor = (qreal)dpi / (qreal)96;
  
  is totally nuts. dpi is already qreal, so 96 is implicitly casted and 96.0f 
or so would have done.
  
  Overmore and far worse, the result is implicitly casted to int scaleFactor, 
ie. truncated - in doubt to 0.
  
  ---
  
  --> scaleFactor should be float/qreal, if you want and then the various 
paddings etc. should be like
  
m_borderLeft = qRound(scaleFactor * border.readEntry("BorderLeft", 
defaultBorderLeft()));
  
  In addition there should be a sanity check on the dpi return and bonus points 
if the dpi is calculated as mean of dpiX and dpiY.
  
  And best invoke Kai Uwe Broulik.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5114

To: mart, #plasma, graesslin
Cc: luebking, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D5114: support for high dpi in aurorae

2017-03-20 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:bfbcd0197181: support for high dpi in aurorae (authored 
by mart).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5114?vs=12648&id=12651

REVISION DETAIL
  https://phabricator.kde.org/D5114

AFFECTED FILES
  plugins/kdecorations/aurorae/src/lib/themeconfig.cpp

To: mart, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol

D5114: support for high dpi in aurorae

2017-03-20 Thread Martin Gräßlin 
graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  phab/auroraedpi

REVISION DETAIL
  https://phabricator.kde.org/D5114

To: mart, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol

D5114: support for high dpi in aurorae

2017-03-20 Thread Marco Martin 
mart added a comment.


  F2991743: LiLiUid.png 

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5114

To: mart, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol

D5114: support for high dpi in aurorae

2017-03-20 Thread Marco Martin 
mart created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.

REVISION SUMMARY
  aurorae themes have hardoded sizes in pixels in their config files,
  but the framesvgs scale by themselves based on font dpi leading
  to corrupt results
  
  scale all sizes using the same logic(that's also used in c++ based
  kdecorations), gives correct looking scaled decorations
  BUG:375868

TEST PLAN
  see screenshot

REPOSITORY
  R108 KWin

BRANCH
  phab/auroraedpi

REVISION DETAIL
  https://phabricator.kde.org/D5114

AFFECTED FILES
  plugins/kdecorations/aurorae/src/lib/themeconfig.cpp

To: mart, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol