D5471: https://bugs.kde.org/show_bug.cgi?id=377994

2017-04-16 Thread Luigi Toscano 
ltoscano added a comment.


  I can't comment on the content of the patch, but I have a comment on the 
titles and the summary.
  
  The content of title+summary+test plan will become the git commit message, so 
I would:
  
  - change the title in a small summary of the change
  - in the body of the summary, no need to write "Resolves 
https://bugs.kde.org/show_bug.cgi?id=377994.;, but simply add a line with:
  
  BUG: 377994
  
  which will do the magic when/if the commit is pushed.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D5471

To: ngraham, #plasma
Cc: ltoscano, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5471: https://bugs.kde.org/show_bug.cgi?id=377994

2017-04-16 Thread Anthony Fieroni 
anthonyfieroni added a reviewer: Plasma.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D5471

To: ngraham, #plasma
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5471: https://bugs.kde.org/show_bug.cgi?id=377994

2017-04-16 Thread Nathaniel Graham 
ngraham created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Makes `/usr/bin/plasmashell --version` the canonical source of truth for the 
Plasma version. Resolves https://bugs.kde.org/show_bug.cgi?id=377994.

TEST PLAN
  Verified original problem by changing the value of X-KDE-PluginInfo-Version 
in  /usr/share/xsessions/plasma5.desktop and seeing that kinfocenter displays 
the new (incorrect) value.
  
  `make test`: passed
  
  Verified changes by deploying rebuilt 
/usr/lib64/qt5/plugins/kcm_about_distro.so file and seeing that kinfoCenter 
does not display the incorrect value in /usr/share/xsessions/plasma5.desktop, 
correctly using the value from `/usr/local/bin/plasmashell --version` instead.
  
  Replaced `/usr/local/bin/plasmashell` with a shell script that displays a 
different value and verified that the different value is displayed in 
kinfocenter
  
  Replaced `/usr/local/bin/plasmashell` with a shell script that displays a 
different value that does not follow the correct format or exits with a nonzero 
status and verified that the output is not displayed in kinfocenter and that it 
correctly falls back to reading the value from the distro-provided .desktop 
file.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D5471

AFFECTED FILES
  Modules/about-distro/src/Module.cpp

To: ngraham
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol