D5505: Keep startup notifications launcher-sized when inserting at launcher position.
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY When "Keep launchers seperate" is disabled, startup notifications replace launchers at their original position. This changes the layout for this mode to keep the startup notification item the size of the launcher item it replaces (the visual result being a throbber on the launcher instead of the launcher being replaced by a "task" with a throbber - iow, the expansion to task size is delayed until a window appears). This helps the minimize the jarring visual fallout in cases where we can match the startup notification to the launcher, but not the window to the startup notification (due to broken/missing window metadata), as no longer will two task-sized items co-exist - instead the throbber comes and goes on the launcher, seperate from the task item for the unidentified window. It also minimizes visual fallout if app startup fails or the app merely creates an SNI instead of a window. This change was suggested by Netrunner Linux, which ships a Task Manager with "Keep launchers seperate" disabled by default. Depends on https://phabricator.kde.org/D5504. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D5505 AFFECTED FILES applets/taskmanager/package/contents/code/layout.js applets/taskmanager/package/contents/ui/main.qml To: hein, #plasma, davidedmundson Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5505: Keep startup notifications launcher-sized when inserting at launcher position.
lukas requested changes to this revision.
lukas added a comment.
This revision now requires changes to proceed.
See the inline comment
INLINE COMMENTS
> main.qml:92
> +property int logicalLauncherCount: {
> +if (plasmoid.configuration.seperateLaunchers) {
> +return launcherCount;
/!\ Evil typo spotted
seperateLaunchers -> separateLaunchers
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5505
To: hein, #plasma, davidedmundson, lukas
Cc: lukas, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
D5505: Keep startup notifications launcher-sized when inserting at launcher position.
hein added a comment. Will fix lukas' error tomorrow, please review past it in the meantime in case there's more :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5505 To: hein, #plasma, davidedmundson, lukas Cc: lukas, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5505: Keep startup notifications launcher-sized when inserting at launcher position.
hein updated this revision to Diff 13625. hein added a comment. Fix typo. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5505?vs=13591&id=13625 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5505 AFFECTED FILES applets/taskmanager/package/contents/code/layout.js applets/taskmanager/package/contents/ui/main.qml To: hein, #plasma, davidedmundson, lukas Cc: lukas, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5505: Keep startup notifications launcher-sized when inserting at launcher position.
broulik accepted this revision.
broulik added inline comments.
INLINE COMMENTS
> main.qml:91
>
> +property int logicalLauncherCount: {
> +if (plasmoid.configuration.separateLaunchers) {
`readonly`
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5505
To: hein, #plasma, davidedmundson, lukas, broulik
Cc: broulik, lukas, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
D5505: Keep startup notifications launcher-sized when inserting at launcher position.
hein updated this revision to Diff 13626. hein added a comment. Add readonly. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5505?vs=13625&id=13626 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5505 AFFECTED FILES applets/taskmanager/package/contents/code/layout.js applets/taskmanager/package/contents/ui/main.qml To: hein, #plasma, davidedmundson, lukas, broulik Cc: broulik, lukas, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5505: Keep startup notifications launcher-sized when inserting at launcher position.
broulik accepted this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5505 To: hein, #plasma, davidedmundson, lukas, broulik Cc: broulik, lukas, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5505: Keep startup notifications launcher-sized when inserting at launcher position.
This revision was automatically updated to reflect the committed changes. Closed by commit R119:3739b4216c58: Keep startup notifications launcher-sized when inserting at launcher position. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5505?vs=13626&id=13633 REVISION DETAIL https://phabricator.kde.org/D5505 AFFECTED FILES applets/taskmanager/package/contents/code/layout.js applets/taskmanager/package/contents/ui/main.qml To: hein, #plasma, davidedmundson, lukas, broulik Cc: broulik, lukas, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
