D5546: Preserve channel balance when changing volume

2017-05-06 Thread David Rosca 
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:462628981947: Preserve channel balance when changing 
volume (authored by drosca).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D5546?vs=13711&id=14205#toc

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5546?vs=13711&id=14205

REVISION DETAIL
  https://phabricator.kde.org/D5546

AFFECTED FILES
  src/context.h
  src/volumeobject.cpp

To: drosca, #plasma, sebas
Cc: sebas, Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, lukas

D5546: Preserve channel balance when changing volume

2017-05-06 Thread Sebastian Kügler 
sebas accepted this revision.
sebas added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> context.h:97
>  if (channel == -1) { // -1 all channels
> +qint64 diff = newVolume - pa_cvolume_avg(&cVolume);
>  for (int i = 0; i < newCVolume.channels; ++i) {

const

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5546

To: drosca, #plasma, sebas
Cc: sebas, Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, lukas

D5546: Preserve channel balance when changing volume

2017-04-23 Thread David Rosca 
drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  BUG: 362832

TEST PLAN
  Works as KMix now

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5546

AFFECTED FILES
  src/context.h
  src/volumeobject.cpp

To: drosca, #plasma
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol