D5684: Move all streams when changing default device
This revision was automatically updated to reflect the committed changes. Closed by commit R115:cb52cc8826d4: Move all streams when changing default device (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5684?vs=14067=14204 REVISION DETAIL https://phabricator.kde.org/D5684 AFFECTED FILES src/context.cpp src/context.h To: drosca, #plasma, sebas Cc: Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5684: Move all streams when changing default device
sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D5684 To: drosca, #plasma, sebas Cc: Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5684: Move all streams when changing default device
drosca added a comment. > Open mpv, which device does it start on? The user will expect DeviceB not DeviceA. It plays on DeviceB for me as expected. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D5684 To: drosca, #plasma Cc: Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5684: Move all streams when changing default device
Zren added a comment. I see you saw the /r/linux thread: https://www.reddit.com/r/linux/comments/68jy8l/kde_users_how_do_you_switch_between_two_audio/ Going to suggest another test: 1. Open mpv with audio playing. 2. Set DeviceA as default 3. Close mpv 4. Set DeviceB as default 5. Open mpv, which device does it start on? The user will expect DeviceB not DeviceA. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D5684 To: drosca, #plasma Cc: Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5684: Move all streams when changing default device
drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When changing default device, it will now also move all streams to this device. TEST PLAN Changed default device, all streams moved to it REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D5684 AFFECTED FILES src/context.cpp src/context.h To: drosca, #plasma Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
