D5723: Cleanup wayland resources used in kwindowsystem before they're deleted by QPA
cfeck added a comment. In https://phabricator.kde.org/D5723#107203, @davidedmundson wrote: > add bug mentioned by cfeck Uhm, where did you add it? REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D5723 To: davidedmundson, #plasma, graesslin Cc: graesslin, cfeck, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5723: Cleanup wayland resources used in kwindowsystem before they're deleted by QPA
This revision was automatically updated to reflect the committed changes. Closed by commit R130:34fc30c4f7ca: Cleanup wayland resources used in kwindowsystem before they're deleted by QPA (authored by davidedmundson). REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5723?vs=14180&id=14184 REVISION DETAIL https://phabricator.kde.org/D5723 AFFECTED FILES src/windowsystem/waylandintegration.cpp To: davidedmundson, #plasma, graesslin Cc: graesslin, cfeck, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5723: Cleanup wayland resources used in kwindowsystem before they're deleted by QPA
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
This is genius, using release! I spent hours on thinking how to properly
clean that up and always came to the conclusion it's not possible as we cannot
properly clean up because we don't get informed when the connection is
destroyed.
INLINE COMMENTS
> waylandintegration.cpp:79
> +if (m_waylandContrastManager) {
> + m_waylandContrastManager->release();
> +}
nitpick: indentation
REPOSITORY
R130 Frameworks integration plugin using KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5723
To: davidedmundson, #plasma, graesslin
Cc: graesslin, cfeck, plasma-devel, spstarr, progwolff, Zren, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5723: Cleanup wayland resources used in kwindowsystem before they're deleted by QPA
davidedmundson updated this revision to Diff 14180. davidedmundson added a comment. add bug mentioned by cfeck REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5723?vs=14177&id=14180 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5723 AFFECTED FILES src/windowsystem/waylandintegration.cpp To: davidedmundson, #plasma Cc: cfeck, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5723: Cleanup wayland resources used in kwindowsystem before they're deleted by QPA
cfeck added a comment. We are tracking the wl_map_insert_at crashes at bug 372597. REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D5723 To: davidedmundson, #plasma Cc: cfeck, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5723: Cleanup wayland resources used in kwindowsystem before they're deleted by QPA
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When the Qt QPA closes it deletes the wl_display deleting wl_display deletes the wl_registry when we destroy the kwayland wrapper we double delete as the windowsystem integration is a singleton we're not deleted till after qApp. By manually releasing the wayland parts early we avoid that problem, whilst still being safe if any app did make a KWindowSystem call during shutdown. BUG: 374665 TEST PLAN Locked screen, no longer crashed when typing in password Opened system settings, created a blurred tooltip then closed. No longer crashed Making a unit test that runs during qApp shutdown will be incredibly difficult. REPOSITORY R130 Frameworks integration plugin using KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D5723 AFFECTED FILES src/windowsystem/waylandintegration.cpp To: davidedmundson, #plasma Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
