D5728: Release the wl_registry before QPA shutdown in QStyl

2017-05-06 Thread Martin Gräßlin
graesslin added a comment.


  I had already investigated the problem, pushed a change and reverted it. I 
think the qstyle gets destroyed too early.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5728

To: davidedmundson, #plasma, hpereiradacosta
Cc: graesslin, cfeck, plasma-devel, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas


D5728: Release the wl_registry before QPA shutdown in QStyl

2017-05-06 Thread David Edmundson
davidedmundson added a comment.


  I uploaded to make it easier for someone to test a patch. It didn't work. 
That's why I'm closing it.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5728

To: davidedmundson, #plasma, hpereiradacosta
Cc: cfeck, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


D5728: Release the wl_registry before QPA shutdown in QStyl

2017-05-06 Thread Christoph Feck
cfeck added a reviewer: hpereiradacosta.
cfeck added a comment.


  Probably needs a similar fix in Oxygen. And if "Registry" is related to 
pixmap/tile caches, it might even fix the shutdown crashes we got there, e.g. 
bug 331260.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5728

To: davidedmundson, #plasma, hpereiradacosta
Cc: cfeck, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


D5728: Release the wl_registry before QPA shutdown in QStyl

2017-05-06 Thread David Edmundson
davidedmundson abandoned this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5728

To: davidedmundson, #plasma
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


D5728: Release the wl_registry before QPA shutdown in QStyl

2017-05-06 Thread David Edmundson
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Otherwise we get a double release as the QPA releases the wl_display
  which deletes the registry.
  
  BUG:

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5728

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas