D5731: Fix regression for timestamp handling for Xwayland windows

2017-05-07 Thread Martin Gräßlin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:32939fa7b522: Fix regression for timestamp handling for 
Xwayland windows (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5731?vs=14210=14218

REVISION DETAIL
  https://phabricator.kde.org/D5731

AFFECTED FILES
  main.h

To: graesslin, #kwin, #plasma, luebking
Cc: sebas, luebking, plasma-devel, kwin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, apol, lukas

D5731: Fix regression for timestamp handling for Xwayland windows

2017-05-06 Thread Thomas Lübking 
luebking accepted this revision.
luebking added a comment.
This revision is now accepted and ready to land.


  Matter of semantics only (if you would want to use the XCB_CURRENT_TIME 
symbol wrt backend abstraction matters and readability - the invalidity isn't 
implicitly explained, maybe read as bool "if (timestamp && ...") but I'm out of 
position for an informed comment on this.

REPOSITORY
  R108 KWin

BRANCH
  fix-timestamp-regression-try2-5.8

REVISION DETAIL
  https://phabricator.kde.org/D5731

To: graesslin, #kwin, #plasma, luebking
Cc: sebas, luebking, plasma-devel, kwin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, apol, lukas

D5731: Fix regression for timestamp handling for Xwayland windows

2017-05-06 Thread Sebastian Kügler 
sebas added subscribers: luebking, sebas.
sebas added a comment.


  @luebking can you have a look?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5731

To: graesslin, #kwin, #plasma
Cc: sebas, luebking, plasma-devel, kwin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, apol, lukas

D5731: Fix regression for timestamp handling for Xwayland windows

2017-05-06 Thread Martin Gräßlin 
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Change 
https://phabricator.kde.org/R108:0bec9ad7337536e319c17c5684d97e1156399fdb 
introduced a regrssion
  on Wayland. On Wayland getTimestamp always returns 0, thus the X11
  timestamp gets reset again and again. This results in broken interaction
  for Xwayland windows as the broken unit tests show.
  
  This change addresses the regression by ignoring a value of 0.
  It means the addressed bug is still present on Wayland for X11 windows
  as the timestamp doesn't get updated properly. This requires further
  changes.

TEST PLAN
  TestShade works again, testX11TimestampUpdate still works

REPOSITORY
  R108 KWin

BRANCH
  fix-timestamp-regression-try2-5.8

REVISION DETAIL
  https://phabricator.kde.org/D5731

AFFECTED FILES
  main.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, lukas