D5757: add requestToggleKeepAbove/below
This revision was automatically updated to reflect the committed changes. Closed by commit R127:e8e88174571c: add requestToggleKeepAbove/below (authored by mart). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14582=14807 REVISION DETAIL https://phabricator.kde.org/D5757 AFFECTED FILES autotests/client/test_plasma_window_model.cpp autotests/client/test_wayland_windowmanagement.cpp src/client/plasmawindowmanagement.cpp src/client/plasmawindowmanagement.h src/client/plasmawindowmodel.cpp src/client/plasmawindowmodel.h To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5757: add requestToggleKeepAbove/below
hein accepted this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5757: add requestToggleKeepAbove/below
mart added a comment. ping? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5757: add requestToggleKeepAbove/below
mart updated this revision to Diff 14582. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - fix comment REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14581=14582 BRANCH arcpatch-D5757 REVISION DETAIL https://phabricator.kde.org/D5757 AFFECTED FILES autotests/client/test_plasma_window_model.cpp autotests/client/test_wayland_windowmanagement.cpp src/client/plasmawindowmanagement.cpp src/client/plasmawindowmanagement.h src/client/plasmawindowmodel.cpp src/client/plasmawindowmodel.h To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
mart marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
mart updated this revision to Diff 14581. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - fix comment REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14320=14581 BRANCH arcpatch-D5757 REVISION DETAIL https://phabricator.kde.org/D5757 AFFECTED FILES autotests/client/test_plasma_window_model.cpp autotests/client/test_wayland_windowmanagement.cpp src/client/plasmawindowmanagement.cpp src/client/plasmawindowmanagement.h src/client/plasmawindowmodel.cpp src/client/plasmawindowmodel.h To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
graesslin added a comment. Your tests in plasma window management do not test the new requests. INLINE COMMENTS > test_wayland_windowmanagement.cpp:483 > +using namespace KWayland::Server; > +// this test verifies setting the showing desktop state > +QVERIFY(!m_window->isKeepAbove()); copy and paste error > test_wayland_windowmanagement.cpp:505 > +using namespace KWayland::Server; > +// this test verifies setting the showing desktop state > +QVERIFY(!m_window->isKeepBelow()); copy and paste error REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
hein added a comment. Well my point was that the patch does add code to both tests (modulo the things you asked to be extended now). REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
graesslin added a comment. In https://phabricator.kde.org/D5757#108706, @hein wrote: > Martin, did you mix things up here maybe? The patch has changes to autotests/client/test_wayland_windowmanagement.cpp. The "newRow" bit isn't related to QAIM. It's a row of test data. no, I answered Marco's question why we need to add code to both tests. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
graesslin added a comment. Forget my last two comments - confused the review REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
graesslin added inline comments.
INLINE COMMENTS
> test_plasma_window_model.cpp:214
>
> void PlasmaWindowModelTest::testRoleNames_data()
> {
Please extend this
> test_plasma_window_model.cpp:306
>
> void PlasmaWindowModelTest::testDefaultData_data()
> {
Please extend this
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
hein added a comment. Martin, did you mix things up here maybe? The patch has changes to autotests/client/test_wayland_windowmanagement.cpp. The "newRow" bit isn't related to QAIM. It's a row of test data. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
graesslin requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
graesslin added a comment. In https://phabricator.kde.org/D5757#108115, @mart wrote: > In https://phabricator.kde.org/D5757#108070, @graesslin wrote: > > > Please also extend the test in autotests/client/test_wayland_windowmanagement.cpp > > > isn't it covered by no, that is a test for the Model. The test for the actual interface is in test_wayland_windowmanagement. That test goes more into the detail of how the interface works. Things we cannot test with the test for the model which only can cover one specific branch. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
mart updated this revision to Diff 14320. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - since 5.35 REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14276=14320 BRANCH phab/abovebelow REVISION DETAIL https://phabricator.kde.org/D5757 AFFECTED FILES autotests/client/test_plasma_window_model.cpp autotests/client/test_wayland_windowmanagement.cpp src/client/plasmawindowmanagement.cpp src/client/plasmawindowmanagement.h src/client/plasmawindowmodel.cpp src/client/plasmawindowmodel.h To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
mart added a comment.
In https://phabricator.kde.org/D5757#108070, @graesslin wrote:
> Please also extend the test in
autotests/client/test_wayland_windowmanagement.cpp
isn't it covered by
QTest::newRow("keepAbove") << ::keepAboveRequested <<
int(ORG_KDE_PLASMA_WINDOW_MANAGEMENT_STATE_KEEP_ABOVE);
QTest::newRow("keepBelow") << ::keepBelowRequested <<
int(ORG_KDE_PLASMA_WINDOW_MANAGEMENT_STATE_KEEP_BELOW);
what do i need to add?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Please also extend the test in autotests/client/test_wayland_windowmanagement.cpp REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
mart updated this revision to Diff 14276. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. autotest REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14273=14276 BRANCH phab/abovebelow REVISION DETAIL https://phabricator.kde.org/D5757 AFFECTED FILES autotests/client/test_plasma_window_model.cpp src/client/plasmawindowmanagement.cpp src/client/plasmawindowmanagement.h src/client/plasmawindowmodel.cpp src/client/plasmawindowmodel.h To: mart, #plasma, hein Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. You also still need to extend PlasmaWindowModel and the unit tests. Everywhere in the kwayland codebase requestToggleMinimized pops up should also have a codepath for these new ones. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
mart updated this revision to Diff 14273. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - since 5.35 REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14263=14273 BRANCH phab/abovebelow REVISION DETAIL https://phabricator.kde.org/D5757 AFFECTED FILES src/client/plasmawindowmanagement.cpp src/client/plasmawindowmanagement.h To: mart, #plasma, hein Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
hein requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
hein added inline comments. INLINE COMMENTS > plasmawindowmanagement.h:407 > + > +/** > + * Requests the window at this model row index have its keep above state > toggled. All these need @since REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas
D5757: add requestToggleKeepAbove/below
mart created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY client requests to toggle those states, to be used by libtaskmanager TEST PLAN setting keep above from the taskbar works REPOSITORY R127 KWayland BRANCH phab/abovebelow REVISION DETAIL https://phabricator.kde.org/D5757 AFFECTED FILES src/client/plasmawindowmanagement.cpp src/client/plasmawindowmanagement.h To: mart, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas
