D5768: Use the first thumbnail as icon for KNS resources
apol added a comment. @leinir remember to close `BUG: 360675` with this one. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5768 To: leinir, apol Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5768: Use the first thumbnail as icon for KNS resources
apol added a comment. In https://phabricator.kde.org/D5768#112774, @mart wrote: > In https://phabricator.kde.org/D5768#112114, @apol wrote: > > > Or we apply it for master and hope Kirigami 2.2 is released before next Plasma release. > > > we can make it happen soon. > i just wanted to know if scroll wheel behavior is alright now, then for what i'm concerned we can release Eh... scroll isn't great, haven't had time to spend on it though. You can do a quick test, you'll see. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5768 To: leinir, apol Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5768: Use the first thumbnail as icon for KNS resources
mart added a comment. In https://phabricator.kde.org/D5768#112114, @apol wrote: > Or we apply it for master and hope Kirigami 2.2 is released before next Plasma release. we can make it happen soon. i just wanted to know if scroll wheel behavior is alright now, then for what i'm concerned we can release REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5768 To: leinir, apol Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5768: Use the first thumbnail as icon for KNS resources
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Or we apply it for master and hope Kirigami 2.2 is released before next Plasma release. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5768 To: leinir, apol Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5768: Use the first thumbnail as icon for KNS resources
apol added a comment. Let's wait until Kirigami 2.2 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5768 To: leinir, apol Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5768: Use the first thumbnail as icon for KNS resources
leinir updated this revision to Diff 14291. leinir added a comment. Have a slightly more useful fallback icon than just nothing (that is, if there is no first thumbnail, use the one it used previously) REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5768?vs=14288=14291 REVISION DETAIL https://phabricator.kde.org/D5768 AFFECTED FILES libdiscover/backends/KNSBackend/KNSResource.cpp To: leinir, apol Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5768: Use the first thumbnail as icon for KNS resources
leinir created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Rather than using the same icon for all KNS based resources, this will return the URL for the first screenshot item. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5768 AFFECTED FILES libdiscover/backends/KNSBackend/KNSResource.cpp To: leinir, apol Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
