D6047: Support XDG v6
This revision was automatically updated to reflect the committed changes. davidedmundson marked an inline comment as done. Closed by commit R127:d4c82b60cf16: Support XDG v6 (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6047?vs=19148=19169#toc REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6047?vs=19148=19169 REVISION DETAIL https://phabricator.kde.org/D6047 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_xdg_shell.cpp autotests/client/test_xdg_shell.h autotests/client/test_xdg_shell_v5.cpp autotests/client/test_xdg_shell_v6.cpp src/client/CMakeLists.txt src/client/protocols/xdg-shell-unstable-v6.xml src/client/registry.cpp src/client/registry.h src/client/xdgshell.cpp src/client/xdgshell.h src/client/xdgshell_p.h src/client/xdgshell_v5.cpp src/client/xdgshell_v6.cpp src/server/CMakeLists.txt src/server/display.cpp src/server/xdgshell_interface.cpp src/server/xdgshell_interface.h src/server/xdgshell_interface_p.h src/server/xdgshell_v5_interface.cpp src/server/xdgshell_v5_interface_p.h src/server/xdgshell_v6_interface.cpp src/server/xdgshell_v6_interface_p.h src/tools/mapping.txt tests/CMakeLists.txt tests/xdgtest.cpp To: davidedmundson, #plasma, graesslin Cc: graesslin, mart, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein
D6047: Support XDG v6
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH temp REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma, graesslin Cc: graesslin, mart, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein
D6047: Support XDG v6
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in xdgshell_interface.cpp:40 > the captured "attempt" variable is modified inside the lambda needs to tack the state as needs to track that only a couple of attempts are made REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma, graesslin Cc: graesslin, mart, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas
D6047: Support XDG v6
davidedmundson updated this revision to Diff 19148. davidedmundson marked an inline comment as done. davidedmundson added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. Rename grab signal REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6047?vs=18807=19148 BRANCH temp REVISION DETAIL https://phabricator.kde.org/D6047 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_xdg_shell.cpp autotests/client/test_xdg_shell.h autotests/client/test_xdg_shell_v5.cpp autotests/client/test_xdg_shell_v6.cpp src/client/CMakeLists.txt src/client/protocols/xdg-shell-unstable-v6.xml src/client/registry.cpp src/client/registry.h src/client/xdgshell.cpp src/client/xdgshell.h src/client/xdgshell_p.h src/client/xdgshell_v5.cpp src/client/xdgshell_v6.cpp src/server/CMakeLists.txt src/server/display.cpp src/server/xdgshell_interface.cpp src/server/xdgshell_interface.h src/server/xdgshell_interface_p.h src/server/xdgshell_v5_interface.cpp src/server/xdgshell_v5_interface_p.h src/server/xdgshell_v6_interface.cpp src/server/xdgshell_v6_interface_p.h src/tools/mapping.txt tests/CMakeLists.txt tests/xdgtest.cpp To: davidedmundson, #plasma, graesslin Cc: graesslin, mart, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas
D6047: Support XDG v6
davidedmundson marked an inline comment as done. davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in xdgshell_interface.cpp:40 > what's the idea behind a mutable lambda? the captured "attempt" variable is modified inside the lambda REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma, graesslin Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6047: Support XDG v6
graesslin added inline comments.
INLINE COMMENTS
> xdgshell_interface.cpp:40
> +int attempt = 0;
> +connect(pingTimer, ::timeout, q, [this, serial, attempt]()
> mutable {
> +++attempt;
what's the idea behind a mutable lambda?
> xdgshell_interface.h:458
> + */
> +void grabbed(KWayland::Server::SeatInterface *seat, quint32 serial);
> +
If it's something the client request, I would suggest a rename to grabRequested.
Could you please explain what "grab" is supposed to be?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6047
To: davidedmundson, #plasma, graesslin
Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6047: Support XDG v6
davidedmundson updated this revision to Diff 18807. davidedmundson marked 10 inline comments as done. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. added some comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6047?vs=17813=18807 BRANCH xdg_merge REVISION DETAIL https://phabricator.kde.org/D6047 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_xdg_shell.cpp autotests/client/test_xdg_shell.h autotests/client/test_xdg_shell_v5.cpp autotests/client/test_xdg_shell_v6.cpp src/client/CMakeLists.txt src/client/protocols/xdg-shell-unstable-v6.xml src/client/registry.cpp src/client/registry.h src/client/xdgshell.cpp src/client/xdgshell.h src/client/xdgshell_p.h src/client/xdgshell_v5.cpp src/client/xdgshell_v6.cpp src/server/CMakeLists.txt src/server/display.cpp src/server/xdgshell_interface.cpp src/server/xdgshell_interface.h src/server/xdgshell_interface_p.h src/server/xdgshell_v5_interface.cpp src/server/xdgshell_v5_interface_p.h src/server/xdgshell_v6_interface.cpp src/server/xdgshell_v6_interface_p.h src/tools/mapping.txt tests/CMakeLists.txt tests/xdgtest.cpp To: davidedmundson, #plasma, graesslin Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6047: Support XDG v6
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. First round of review, client api is done. INLINE COMMENTS > registry.h:1275 > + * @param name The name for the removed interface > + * @since 5.25 > + **/ careful here: the since won't match > xdgshell.h:95 > + > +/* > + * Which edge of the anchor should the popup be positioned around In case you wanted to make those comments doxygen comments: you need to use /** instead of /* Applies for all comments in this class. > xdgshell.h:176 > + > +void setup(zxdg_shell_v6 *xdgshellv6); > + lacking documentation including an @since. > xdgshell.h:222 > **/ > XdgShellPopup *createPopup(Surface *surface, Surface *parentSurface, > Seat *seat, quint32 serial, const QPoint , QObject *parent = > nullptr); > If the comment is deprecated, the method should be deprecated as well. But I disagree on the point of deprecation. It is not deprecated if it's used with xdgShellv5. That should probably just be documented properly. > xdgshell.h:226 > + * Creates a new XdgShellPopup for the given @p surface on top of @p > parentSurface with the given @p positioner. > + **/ > +XdgShellPopup *createPopup(Surface *surface, XdgShellSurface > *parentSurface, const XdgPositioner , QObject *parent = nullptr); @since missing > xdgshell.h:229 > + > +/** > + * Creates a new XdgShellPopup for the given @p surface on top of @p > parentSurface with the given @p positioner. looks like wrong indentation. > xdgshell.h:231 > + * Creates a new XdgShellPopup for the given @p surface on top of @p > parentSurface with the given @p positioner. > + **/ > +XdgShellPopup *createPopup(Surface *surface, XdgShellPopup > *parentSurface, const XdgPositioner , QObject *parent = nullptr); @since missing > xdgshell.h:302 > + > +void setup(zxdg_surface_v6 *xdgsurfacev6, zxdg_toplevel_v6 *toplevel); > + missing documentation. > xdgshell.h:427 > > +/* > + * Set this surface to have a given maximum size same as with the other class: that's not a documentation comment. > xdgshell.h:500 > + * method. > + **/ > +void setup(zxdg_surface_v6 *xdgsurfacev6, zxdg_popup_v6 *xdgpopup6); @since missing > xdgshell.h:562 > +/** > + * > + **/ documentation missing > xdgshell_p.h:67 > +Q_UNUSED(parent) > +qWarning() << __func__ << " is not supported in this version"; > +return nullptr; Please no qWarning. Either qCWarning or not at all. > xdgshell_v6.cpp:28 > + > +#include > + I don't see any debug messages in this file REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma, graesslin Cc: graesslin, mart, plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas
D6047: Support XDG v6
davidedmundson updated this revision to Diff 17813. davidedmundson added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. Unbind global Add a test for transientFor REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6047?vs=15889=17813 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6047 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_xdg_shell.cpp autotests/client/test_xdg_shell.h autotests/client/test_xdg_shell_v5.cpp autotests/client/test_xdg_shell_v6.cpp src/client/CMakeLists.txt src/client/protocols/xdg-shell-unstable-v6.xml src/client/registry.cpp src/client/registry.h src/client/xdgshell.cpp src/client/xdgshell.h src/client/xdgshell_p.h src/client/xdgshell_v5.cpp src/client/xdgshell_v6.cpp src/server/CMakeLists.txt src/server/display.cpp src/server/xdgshell_interface.cpp src/server/xdgshell_interface.h src/server/xdgshell_interface_p.h src/server/xdgshell_v5_interface.cpp src/server/xdgshell_v5_interface_p.h src/server/xdgshell_v6_interface.cpp src/server/xdgshell_v6_interface_p.h src/tools/mapping.txt tests/CMakeLists.txt tests/xdgtest.cpp To: davidedmundson, #plasma Cc: graesslin, mart, plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas
D6047: Support XDG v6
davidedmundson retitled this revision from "WIP: Support XDG v6" to "Support XDG v6". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
