D6059: Close notifications that don't have a default action by clicking

2017-06-01 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 15069.
apol added a comment.


  Just add a test

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6059?vs=15052&id=15069

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6059

AFFECTED FILES
  applets/notifications/package/contents/tests/test.qml
  applets/notifications/package/contents/ui/Notifications.qml
  applets/notifications/plugin/notificationshelper.cpp
  applets/notifications/plugin/notificationshelper.h

To: apol, #plasma, broulik, #vdg
Cc: mart, mck182, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D6059: Close notifications that don't have a default action by clicking

2017-06-01 Thread Aleix Pol Gonzalez 
apol added a comment.


  In https://phabricator.kde.org/D6059#113450, @mck182 wrote:
  
  > This was discussed at length in https://phabricator.kde.org/D4215
  >
  > What's the reasoning behind this change?
  
  
  The reasoning is Kai complained about it in IRC. If it was decided against 
I'll redo the patch keeping the test and closing the notification differently.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6059

To: apol, #plasma, broulik, #vdg
Cc: mart, mck182, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D6059: Close notifications that don't have a default action by clicking

2017-06-01 Thread Marco Martin 
mart added a comment.


  triggering the action would close the notification anyways, so it may be seen 
as a consistency between notifications with action and not

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6059

To: apol, #plasma, broulik, #vdg
Cc: mart, mck182, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D6059: Close notifications that don't have a default action by clicking

2017-06-01 Thread Martin Klapetek 
mck182 added a comment.


  This was discussed at length in https://phabricator.kde.org/D4215
  
  What's the reasoning behind this change?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6059

To: apol, #plasma, broulik, #vdg
Cc: mck182, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6059: Close notifications that don't have a default action by clicking

2017-06-01 Thread Kai Uwe Broulik 
broulik added a reviewer: VDG.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6059

To: apol, #plasma, broulik, #vdg
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6059: Close notifications that don't have a default action by clicking

2017-06-01 Thread Aleix Pol Gonzalez 
apol created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  Adds a test

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6059

AFFECTED FILES
  applets/notifications/package/contents/tests/test.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/Notifications.qml
  applets/notifications/plugin/notificationshelper.cpp
  applets/notifications/plugin/notificationshelper.h

To: apol, #plasma, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas