D6260: Better handle cases when the xkb keymap fails to be created
This revision was automatically updated to reflect the committed changes. Closed by commit R108:0df09a8cbbb1: Better handle cases when the xkb keymap fails to be created (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6260?vs=15551&id=15614 REVISION DETAIL https://phabricator.kde.org/D6260 AFFECTED FILES autotests/integration/CMakeLists.txt autotests/integration/keymap_creation_failure_test.cpp xkb.cpp To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6260: Better handle cases when the xkb keymap fails to be created
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH safety-checks-xkbcommon-5.10 REVISION DETAIL https://phabricator.kde.org/D6260 To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6260: Better handle cases when the xkb keymap fails to be created
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY If the keymap cannot be created a few pointers in Xkb are null. We should make sure to not call any xkbcommon functions on those null pointers and instead use proper fallbacks. This change introduces fixes for a few usages, but it's not unlikely that there are more cases. BUG: 381210 FIXED-IN: 5.10.3 TEST PLAN Autotest added for the condition of the bug, which does not crash any more. Just starting the test found a few more crash cases. REPOSITORY R108 KWin BRANCH safety-checks-xkbcommon-5.10 REVISION DETAIL https://phabricator.kde.org/D6260 AFFECTED FILES autotests/integration/CMakeLists.txt autotests/integration/keymap_creation_failure_test.cpp xkb.cpp To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
