D6388: Don't use plasma theme icons for stream/device icons
drosca added a comment. Ping? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D6388 To: broulik, #plasma, drosca, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D6388: Don't use plasma theme icons for stream/device icons
drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. If we want this, then only for applications tab (streams), because there is no reason not to use Plasma theme for device icons (those are standard freedesktop icon names). REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D6388 To: broulik, #plasma, drosca, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6388: Don't use plasma theme icons for stream/device icons
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D6388 To: broulik, #plasma, drosca, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6388: Don't use plasma theme icons for stream/device icons
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN VLC has a Plasma icon now and we get a mix of apps and plasma icons. We typically don't use plasma theme for app-heavy things like task manager, launcher, etc REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D6388 AFFECTED FILES applet/contents/ui/ListItemBase.qml To: broulik, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
