D6523: check Buffer validity
graesslin added a comment. Erm why was this pushed although it was in state changes requested? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6523 To: mart, #plasma, davidedmundson, graesslin Cc: graesslin, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6523: check Buffer validity
This revision was automatically updated to reflect the committed changes. Closed by commit R127:dd8e084a685e: check Buffer validity (authored by mart). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6523?vs=16229&id=16242 REVISION DETAIL https://phabricator.kde.org/D6523 AFFECTED FILES src/client/shadow.cpp To: mart, #plasma, davidedmundson, graesslin Cc: graesslin, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6523: check Buffer validity
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. please add a test case for the problem. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6523 To: mart, #plasma, davidedmundson, graesslin Cc: graesslin, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6523: check Buffer validity
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D6523 To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6523: check Buffer validity
mart added a comment. In https://phabricator.kde.org/D6523#122107, @davidedmundson wrote: > Same question as before, what happens when we go from a theme with shadows to a theme without? I tried to switch back and forth several times between breeze and keramiek(the theme linked in the bug which could reproduce the crash) and all seems to be fine the shadows go from visible to absent and back and doesn't crash REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6523 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6523: check Buffer validity
davidedmundson added a comment. Same question as before, what happens when we go from a theme with shadows to a theme without? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6523 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6523: check Buffer validity
mart created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY if a plasma theme doesn't provide shadow graphics, the buffer will be a nullptr as would be created from an invalid image and would crash BUG:381953 TEST PLAN no crash anymore when using a theme that doesn't provide shadows REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D6523 AFFECTED FILES src/client/shadow.cpp To: mart, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
