D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-09-27 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:ef156a238298: Look for QtGraphicalEffects, so packagers 
dont forget it (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6549?vs=17925=19996

REVISION DETAIL
  https://phabricator.kde.org/D6549

AFFECTED FILES
  CMakeLists.txt

To: apol, #kirigami, sitter, mart, davidedmundson
Cc: graesslin, plasma-devel, apol, davidedmundson, mart, hein

D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-08-12 Thread Martin Flöser 
graesslin added a comment.


  In https://phabricator.kde.org/D6549#134794, @apol wrote:
  
  > I was thinking: should I wait for a month so that ECM has been released 
with it maybe? Otherwise it will be a hard dependency and people won't be able 
to use the master branch...
  
  
  I think it's totally fine for a framework master to depend on ECM master. At 
least for KWin I think I'll introduce this ecm_find_qmlmodule without waiting 
another month ;-)

REPOSITORY
  R169 Kirigami

BRANCH
  arcpatch-D6549

REVISION DETAIL
  https://phabricator.kde.org/D6549

To: apol, #kirigami, sitter, mart, davidedmundson
Cc: graesslin, plasma-devel, apol, mart

D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-08-11 Thread Aleix Pol Gonzalez 
apol added a comment.


  I was thinking: should I wait for a month so that ECM has been released with 
it maybe? Otherwise it will be a hard dependency and people won't be able to 
use the master branch...

REPOSITORY
  R169 Kirigami

BRANCH
  arcpatch-D6549

REVISION DETAIL
  https://phabricator.kde.org/D6549

To: apol, #kirigami, sitter, mart, davidedmundson
Cc: plasma-devel, apol, mart

D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-08-09 Thread Harald Sitter 
sitter accepted this revision.
sitter added a comment.


  lovely jubbly!

REPOSITORY
  R169 Kirigami

BRANCH
  arcpatch-D6549

REVISION DETAIL
  https://phabricator.kde.org/D6549

To: apol, #kirigami, sitter, mart, davidedmundson
Cc: plasma-devel, apol, mart

D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-08-09 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  arcpatch-D6549

REVISION DETAIL
  https://phabricator.kde.org/D6549

To: apol, #kirigami, sitter, mart, davidedmundson
Cc: plasma-devel, apol, mart

D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-08-09 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 17925.
apol added a comment.


  Use the macro in ECM now

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6549?vs=16296=17925

BRANCH
  arcpatch-D6549

REVISION DETAIL
  https://phabricator.kde.org/D6549

AFFECTED FILES
  CMakeLists.txt

To: apol, #kirigami, sitter, mart
Cc: plasma-devel, apol, mart

D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-08-03 Thread Aleix Pol Gonzalez 
apol planned changes to this revision.
apol added a comment.


  Need to be rebased on top of https://phabricator.kde.org/D7094 when it's 
merged.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D6549

To: apol, #kirigami, sitter, mart
Cc: plasma-devel, apol, mart

D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-08-01 Thread Marco Martin 
mart added a comment.


  any update on this?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D6549

To: apol, #kirigami, sitter, mart
Cc: plasma-devel, apol, mart

D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-07-07 Thread Aleix Pol Gonzalez 
apol added a comment.


  In https://phabricator.kde.org/D6549#122629, @sitter wrote:
  
  > Probably should go to ECM instead of being copy pasted.
  
  
  Yes, right... xD

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D6549

To: apol, #kirigami, sitter, mart
Cc: plasma-devel, apol, mart

D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-07-07 Thread Harald Sitter 
sitter added a comment.


  Probably should go to ECM instead of being copy pasted.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D6549

To: apol, #kirigami, sitter, mart
Cc: plasma-devel, apol, mart

D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-07-07 Thread Aleix Pol Gonzalez 
apol created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6549

AFFECTED FILES
  CMakeLists.txt
  cmake/FindQMLModule.cmake.in
  cmake/QMLModules.cmake

To: apol, #kirigami, sitter, mart
Cc: plasma-devel, apol, mart