D6719: [aurorae] Add support for shaded windows

2017-07-17 Thread Martin Flöser 
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:bf0e0f071ceb: [aurorae] Add support for shaded windows 
(authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6719?vs=16774=16825

REVISION DETAIL
  https://phabricator.kde.org/D6719

AFFECTED FILES
  plugins/kdecorations/aurorae/src/aurorae.cpp
  plugins/kdecorations/aurorae/src/qml/Decoration.qml

To: graesslin, #kwin, #plasma, cfeck
Cc: cfeck, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6719: [aurorae] Add support for shaded windows

2017-07-16 Thread Christoph Feck 
cfeck accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  aurorae-support-shaded

REVISION DETAIL
  https://phabricator.kde.org/D6719

To: graesslin, #kwin, #plasma, cfeck
Cc: cfeck, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6719: [aurorae] Add support for shaded windows

2017-07-16 Thread Martin Flöser 
graesslin added inline comments.

INLINE COMMENTS

> cfeck wrote in aurorae.cpp:407
> Do you remember why the other connection needed to be queued?

Yes, when maximizing it can happen that the deco gets destroyed. It would act 
like a delete this without the queued connection. With shade this cannot 
happen, so no need to queue.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6719

To: graesslin, #kwin, #plasma
Cc: cfeck, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6719: [aurorae] Add support for shaded windows

2017-07-16 Thread Christoph Feck 
cfeck added inline comments.

INLINE COMMENTS

> aurorae.cpp:407
>  connect(client().data(), 
> ::DecoratedClient::maximizedChanged, this, 
> ::updateBorders, Qt::QueuedConnection);
> +connect(client().data(), ::DecoratedClient::shadedChanged, 
> this, ::updateBorders);
>  updateBorders();

Do you remember why the other connection needed to be queued?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6719

To: graesslin, #kwin, #plasma
Cc: cfeck, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6719: [aurorae] Add support for shaded windows

2017-07-16 Thread Martin Flöser 
graesslin updated this revision to Diff 16774.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  New approach to the problem

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6719?vs=16748=16774

BRANCH
  aurorae-support-shaded

REVISION DETAIL
  https://phabricator.kde.org/D6719

AFFECTED FILES
  plugins/kdecorations/aurorae/src/aurorae.cpp
  plugins/kdecorations/aurorae/src/qml/Decoration.qml

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6719: [aurorae] Add support for shaded windows

2017-07-15 Thread Martin Flöser 
graesslin planned changes to this revision.
graesslin added a comment.


  Unfortunately there are still themes which cause glitches.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6719

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6719: [aurorae] Add support for shaded windows

2017-07-15 Thread Martin Flöser 
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Aurorae did not render correctly. This change addresses the problem for
  both maximized and restored windows.
  
  BUG: 373319
  FIXED-IN: 5.10.4

TEST PLAN
  shaded windows with Plastik and SVG based theme

REPOSITORY
  R108 KWin

BRANCH
  aurorae-support-shaded

REVISION DETAIL
  https://phabricator.kde.org/D6719

AFFECTED FILES
  plugins/kdecorations/aurorae/src/aurorae.cpp
  plugins/kdecorations/aurorae/src/qml/Decoration.qml
  plugins/kdecorations/aurorae/src/qml/aurorae.qml
  plugins/kdecorations/aurorae/themes/plastik/package/contents/ui/main.qml

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas