D6746: Fix check for missing engine in comic applet

2017-07-16 Thread David Edmundson 
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Current code would check the comic engine was not installed and not create the
  download dialog, but would still always try to show it. This would
  crash.
  
  BUG: 372313

TEST PLAN
  Code review

REPOSITORY
  R114 Plasma Addons

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6746

AFFECTED FILES
  applets/comic/comic.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6746: Fix check for missing engine in comic applet

2017-07-16 Thread Anthony Fieroni 
anthonyfieroni accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R114 Plasma Addons

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6746

To: davidedmundson, #plasma, anthonyfieroni
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6746: Fix check for missing engine in comic applet

2017-07-17 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:8aa47be2abe6: Fix check for missing engine in comic 
applet (authored by davidedmundson).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6746?vs=16796&id=16807

REVISION DETAIL
  https://phabricator.kde.org/D6746

AFFECTED FILES
  applets/comic/comic.cpp

To: davidedmundson, #plasma, anthonyfieroni
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas