D6813: Use customized font size for Digital Clock applet

2019-09-16 Thread Yunhe Guo 
guoyunhe abandoned this revision.
guoyunhe added a comment.


  It seems not possible to set font size because others insist the font size 
should grow with panel. Another alternative widget might be better way to push 
forward.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6813

To: guoyunhe, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6813: Use customized font size for Digital Clock applet

2017-08-20 Thread Nathaniel Graham 
ngraham added a comment.


  Any reasons not to land this or https://phabricator.kde.org/D6764?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6813

To: guoyunhe, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6813: Use customized font size for Digital Clock applet

2017-07-21 Thread Yunhe Guo 
guoyunhe added a comment.


  In https://phabricator.kde.org/D6813#127279, @davidedmundson wrote:
  
  > Thanks, FYI we've had another review with the same change this week: 
https://phabricator.kde.org/D6764
  
  
  Good to know  

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6813

To: guoyunhe, #plasma_workspaces
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6813: Use customized font size for Digital Clock applet

2017-07-21 Thread David Edmundson 
davidedmundson added a comment.


  Thanks, FYI we've had another review with the same change this week: 
https://phabricator.kde.org/D6764
  
  There's some comments there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6813

To: guoyunhe, #plasma_workspaces
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6813: Use customized font size for Digital Clock applet

2017-07-21 Thread Yunhe Guo 
guoyunhe created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  > This patch is not tested! I have some trouble to compile or run Plasma 
Workspace. Hope someone could help me test or give some build/test instruction. 
:-)
  
  The "Digital Clock" applet uses panel height or applet height to decide the 
font size. If the panel is 50px high, the "Digital Clock" applet would have a 
huge font size around 48px. (without date or timezone) This is too big for many 
users.
  
  In other desktop environment, like Unity, GNOME, Windows, macOS, similar date 
time applets have fixed font size that equals to the default UI font size.
  
  This patch would add a "Font size" option to appearance configuration dialog.
  
  If not set a font size, it uses "Default", the default font size of Plamsa. 
If a value was set, it will use the specific font size. It still follow the 
panel size and applet size limits. So the font size should never be larger than 
label height.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6813

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: guoyunhe, #plasma_workspaces
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas