D7246: Tooltips
This revision was automatically updated to reflect the committed changes. Closed by commit R129:24a859b356ef: Tooltips (authored by graesslin). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=25539&id=25604 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt autotests/mockclient.cpp autotests/mockclient.h src/CMakeLists.txt src/decoration.cpp src/decoration.h src/decorationbutton.cpp src/decorationbutton_p.h src/private/CMakeLists.txt src/private/decoratedclientprivate.h To: McPain, #breeze, #plasma, graesslin Cc: cfeck, davidedmundson, jriddell, ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
graesslin accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: cfeck, davidedmundson, jriddell, ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain updated this revision to Diff 25539. McPain added a comment. Fix autotests build CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=25145&id=25539 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt autotests/mockclient.cpp autotests/mockclient.h src/CMakeLists.txt src/decoration.cpp src/decoration.h src/decorationbutton.cpp src/decorationbutton_p.h src/private/CMakeLists.txt src/private/decoratedclientprivate.h To: McPain, #breeze, #plasma, graesslin Cc: cfeck, davidedmundson, jriddell, ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I get compile errors: /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockbridge.cpp: In member function ‘virtual std::unique_ptr MockBridge::createClient(KDecoration2::DecoratedClient*, KDecoration2::Decoration*)’: /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockbridge.cpp:27:77: error: invalid new-expression of abstract class type ‘MockClient’ auto ptr = std::unique_ptr(new MockClient(client, decoration)); ^ In file included from /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockbridge.cpp:21:0: /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockclient.h:27:7: note: because the following virtual functions are pure within ‘MockClient’: class MockClient : public QObject, public KDecoration2::ApplicationMenuEnabledDecoratedClientPrivate ^~ In file included from /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockclient.h:23:0, from /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockbridge.cpp:21: /home/martin/src/kf5/kde/workspace/kdecoration/autotests/../src/private/decoratedclientprivate.h:79:18: note: virtual void KDecoration2::DecoratedClientPrivate::requestShowToolTip(const QString&) virtual void requestShowToolTip(const QString &text) = 0; ^~ /home/martin/src/kf5/kde/workspace/kdecoration/autotests/../src/private/decoratedclientprivate.h:80:18: note: virtual void KDecoration2::DecoratedClientPrivate::requestHideToolTip() virtual void requestHideToolTip() = 0; ^~ [ 72%] Building CXX object autotests/CMakeFiles/decorationButtonTest.dir/mockdecoration.cpp.o autotests/CMakeFiles/decorationTest.dir/build.make:62: recipe for target 'autotests/CMakeFiles/decorationTest.dir/mockbridge.cpp.o' failed make[2]: *** [autotests/CMakeFiles/decorationTest.dir/mockbridge.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: cfeck, davidedmundson, jriddell, ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain updated this revision to Diff 25145. McPain marked 4 inline comments as done. McPain added a comment. const QString & cleanup CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=25084&id=25145 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/decoration.cpp src/decoration.h src/decorationbutton.cpp src/decorationbutton_p.h src/private/CMakeLists.txt src/private/decoratedclientprivate.h To: McPain, #breeze, #plasma, graesslin Cc: cfeck, davidedmundson, jriddell, ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
cfeck added inline comments.
INLINE COMMENTS
> decoration.h:179
> void requestShowWindowMenu();
> +void requestShowToolTip(QString text);
> +void requestHideToolTip();
const QString &text
> decorationbutton.cpp:292
> +{
> +
> +switch (type) {
empty line
> decorationbutton_p.h:69
>
> +QString typeToString( DecorationButtonType type );
> +
Does kwin use this "spaces inside parentheses" style?
> decoratedclientprivate.h:79
>
> +virtual void requestShowToolTip(QString &text) = 0;
> +virtual void requestHideToolTip() = 0;
const QString &
REVISION DETAIL
https://phabricator.kde.org/D7246
To: McPain, #breeze, #plasma, graesslin
Cc: cfeck, davidedmundson, jriddell, ngraham, broulik, plasma-devel, #breeze,
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, mart
D7246: Tooltips
graesslin accepted this revision. graesslin added subscribers: jriddell, davidedmundson. graesslin added a comment. This revision is now accepted and ready to land. We are close to release and this might create hassles for distributions. Should we include it or wait for master being open again? @davidedmundson, @jriddell: what's your opinion? My personal opinion is that we should try to get it into 5.12 given that this was in the known issues section since the introduction of kdecoration2. REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: davidedmundson, jriddell, ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain updated this revision to Diff 25084. McPain added a comment. fix build CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=25083&id=25084 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/decoration.cpp src/decoration.h src/decorationbutton.cpp src/decorationbutton_p.h src/private/CMakeLists.txt src/private/decoratedclientprivate.h To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain updated this revision to Diff 25083. McPain marked 11 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=23866&id=25083 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/decoration.cpp src/decoration.h src/decorationbutton.cpp src/decorationbutton_p.h src/private/CMakeLists.txt src/private/decoratedclientprivate.h To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
graesslin added inline comments. INLINE COMMENTS > McPain wrote in decoratedclientprivate.h:79-80 > I need to avoid sover increasing, right? No, increasing the soversion of the private library is fine. It's only used by KWin and by KDecoration public library. The interface to the decoration plugins (like breeze) is still stable. As KDecoration and KWin are released together it's not a problem. But we should try to get it in before the beta release as distros might need to adjust packaging. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain added inline comments. INLINE COMMENTS > graesslin wrote in decoratedclientprivate.h:79-80 > If we add pure virtuals we need to increase the so version of the private > libraru. I need to avoid sover increasing, right? REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:27 > Test > +Widgets > ) I don't see Widgets used anywhere. > CMakeLists.txt:1 > +add_definitions(-DTRANSLATION_DOMAIN="kcmkwindecoration") > + This is not kcmkwin, but kdecoration > CMakeLists.txt:22 > Qt5::Gui > +Qt5::Widgets > PRIVATE I don't see Widgets used anywhere > decorationbutton.cpp:302 > connect(this, &DecorationButton::hoveredChanged, this, updateSlot); > +connect(this, &DecorationButton::hoveredChanged, this, > &DecorationButton::showTooltip); > connect(this, &DecorationButton::pressedChanged, this, updateSlot); If I see correctly this could become a lambda function which would not require to add a showTooltip method > decorationbutton.cpp:512-513 > + > +//TODO: change offset to something valuable > +hovered ? emit showtooltip(type) : hidetooltip(); > + Instead of emitting the signal please invoke the method requestShowTooltip directly (I don't think we need to queue it) > decorationbutton.h:155-156 > > +//* show tooltip > +void showTooltip(bool); > + I think this method is not needed (see comment about the lambda connection) > decorationbutton.h:158 > + > +QString typeToString( DecorationButtonType type ); > + This should not be in the public header. Please move to private > decorationbutton.h:167-168 > void doubleClicked(); > +void showtooltip(QString); > +void hidetooltip(); > I don't think we need those signals. > decoratedclientprivate.h:79-80 > > +virtual void requestShowToolTip(QString &text) = 0; > +virtual void requestHideToolTip() = 0; > virtual void requestClose() = 0; If we add pure virtuals we need to increase the so version of the private libraru. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain updated this revision to Diff 23866. REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=23862&id=23866 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES kdecoration-5.11.3/CMakeLists.txt kdecoration-5.11.3/src/CMakeLists.txt kdecoration-5.11.3/src/decoration.cpp kdecoration-5.11.3/src/decoration.h kdecoration-5.11.3/src/decorationbutton.cpp kdecoration-5.11.3/src/decorationbutton.h kdecoration-5.11.3/src/private/decoratedclientprivate.h To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain updated this revision to Diff 23862. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=23857&id=23862 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES kdecoration-5.11.3/CMakeLists.txt kdecoration-5.11.3/src/CMakeLists.txt kdecoration-5.11.3/src/decoration.cpp kdecoration-5.11.3/src/decoration.h kdecoration-5.11.3/src/decorationbutton.cpp kdecoration-5.11.3/src/decorationbutton.h kdecoration-5.11.3/src/private/decoratedclientprivate.h To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain updated this revision to Diff 23857. REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=23854&id=23857 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES kdecoration-5.11.3/CMakeLists.txt kdecoration-5.11.3/src/CMakeLists.txt kdecoration-5.11.3/src/decoration.cpp kdecoration-5.11.3/src/decoration.h kdecoration-5.11.3/src/decorationbutton.cpp kdecoration-5.11.3/src/decorationbutton.h kdecoration-5.11.3/src/private/decoratedclientprivate.h To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain updated this revision to Diff 23854. McPain added a comment. Removed "bool trap" REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=23794&id=23854 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES kdecoration-5.11.3/CMakeLists.txt kdecoration-5.11.3/src/CMakeLists.txt kdecoration-5.11.3/src/decoration.cpp kdecoration-5.11.3/src/decoration.h kdecoration-5.11.3/src/decorationbutton.cpp kdecoration-5.11.3/src/decorationbutton.h kdecoration-5.11.3/src/private/decoratedclientprivate.h To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain edited the summary of this revision. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain updated this revision to Diff 23794. McPain added a comment. Moved QToolTip::showText to KWin REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=22886&id=23794 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES kdecoration-5.11.3/CMakeLists.txt kdecoration-5.11.3/src/CMakeLists.txt kdecoration-5.11.3/src/decoration.cpp kdecoration-5.11.3/src/decoration.h kdecoration-5.11.3/src/decorationbutton.cpp kdecoration-5.11.3/src/decorationbutton.h kdecoration-5.11.3/src/private/decoratedclientprivate.h To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
graesslin added a comment.
In https://phabricator.kde.org/D7246#178385, @McPain wrote:
> One more question:
>
> can this cause a memory leak?
>
> void Workspace::showTooltip(const QString& text, const QPoint &pos, bool
show){
> show ? QToolTip::showText(pos, text) : QToolTip::hideText();
> }
>
I think that's safe.
REPOSITORY
R129 Window Decoration Library
REVISION DETAIL
https://phabricator.kde.org/D7246
To: McPain, #breeze, #plasma, graesslin
Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain added a comment.
One more question:
can this cause a memory leak?
void Workspace::showTooltip(const QString& text, const QPoint &pos, bool
show){
show ? QToolTip::showText(pos, text) : QToolTip::hideText();
}
REPOSITORY
R129 Window Decoration Library
REVISION DETAIL
https://phabricator.kde.org/D7246
To: McPain, #breeze, #plasma, graesslin
Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
graesslin added a comment. In https://phabricator.kde.org/D7246#177383, @McPain wrote: > In https://phabricator.kde.org/D7246#171923, @graesslin wrote: > > > But long story short: for KWin the best is a request from KDecoration "showTooltip(const QString &)" and KWin creates the tooltip window, positions it and ensures it works correctly. > > > Any idea where exactly in KWin it should be? In KWin sources there is a subdirectory called decorations. Inside that is the complete decoration integration code. I guess the best place might be in the bridge or in the decorated client impl. So a request from KDecoration could go through the bridge where KWin can create the tooltip. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain added a comment. In https://phabricator.kde.org/D7246#171923, @graesslin wrote: > But long story short: for KWin the best is a request from KDecoration "showTooltip(const QString &)" and KWin creates the tooltip window, positions it and ensures it works correctly. Any idea where exactly in KWin it should be? REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
graesslin added a comment. In https://phabricator.kde.org/D7246#171908, @graesslin wrote: > I'm sorry, but Widgets is a dependency which cannot be used for it. This creates problems in KWin. Tooltip support must be implemented directly in KWin, exposed through the KDecoration API. Yes I know that makes it rather complex, but that's the reason why tooltip support wasn't added to KDecoration through QWidget in the first place. I thought a little bit more about it. It might be possible to use QWidgets if it's done inside KWin. That might work correctly. If it's not directly controlled by KWin, it's problematic and will most likely not work correctly. To explain: KWin has difficulties creating windows. I know it sounds stupid, that the window manager is not able to create windows, but that's how it is. KWin has to do quite some tricks and track windows internally. If a window gets created by a library loaded into KWin and KWin doesn't know about it, such internal tracking breaks. It now has a window it doesn't know about. That's especially a problem on Wayland, on X11 it works better for windows such as a tooltip. But long story short: for KWin the best is a request from KDecoration "showTooltip(const QString &)" and KWin creates the tooltip window, positions it and ensures it works correctly. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
graesslin added a comment. I'm sorry, but Widgets is a dependency which cannot be used for it. This creates problems in KWin. Tooltip support must be implemented directly in KWin, exposed through the KDecoration API. Yes I know that makes it rather complex, but that's the reason why tooltip support wasn't added to KDecoration through QWidget in the first place. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain updated this revision to Diff 22886. REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=22872&id=22886 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/decorationbutton.cpp src/decorationbutton.h To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain updated this revision to Diff 22872. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=17995&id=22872 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/decorationbutton.cpp src/decorationbutton.h To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
McPain retitled this revision from "Tooltips in Breeze theme" to "Tooltips". McPain changed the repository for this revision from R31 Breeze to R129 Window Decoration Library. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips in Breeze theme
ngraham added a comment. Probably redo the patch so that it can apply to any theme. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips in Breeze theme
ngraham edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips in Breeze theme
McPain added a comment. In https://phabricator.kde.org/D7246#158488, @ngraham wrote: > @McPain, any update? Not now. I don't get what to do: rewrite entire patch or write it for oxygen? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips in Breeze theme
ngraham added a comment. @McPain, any update? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips in Breeze theme
broulik added a comment. Thanks for your patch, however I think this should rather to into KDecoration itself so every decoration, not just Breeze, takes advantage of it. However, from what I can tell KDecoration is QtGui-only (not QtWidgets), I looked into it once but didn't want to pull in widgets just for `QToolTip`. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze Cc: broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7246: Tooltips in Breeze theme
broulik added reviewers: Plasma, graesslin. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7246: Tooltips in Breeze theme
McPain created this revision. McPain added projects: Plasma, Breeze. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY https://bugs.kde.org/show_bug.cgi?id=383040 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES kdecoration/breezebutton.cpp kdecoration/breezebutton.h To: McPain, #breeze Cc: plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
