D7268: Use new libtm API to enable DND reordering within group dialogs.

2017-08-14 Thread Eike Hein 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7db2a6fbe394: Use new libtm API to enable DND reordering 
within group dialogs. (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7268?vs=18121=18129

REVISION DETAIL
  https://phabricator.kde.org/D7268

AFFECTED FILES
  applets/taskmanager/package/contents/ui/MouseHandler.qml

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7268: Use new libtm API to enable DND reordering within group dialogs.

2017-08-14 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7268

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7268: Use new libtm API to enable DND reordering within group dialogs.

2017-08-14 Thread Eike Hein 
hein updated this revision to Diff 18121.
hein added a comment.


  Move check into dragging block.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7268?vs=18034=18121

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7268

AFFECTED FILES
  applets/taskmanager/package/contents/ui/MouseHandler.qml

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7268: Use new libtm API to enable DND reordering within group dialogs.

2017-08-12 Thread David Edmundson 
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> MouseHandler.qml:102
> +// Reject drags between different TaskList instances.
> +if (tasks.dragSource.parent != above.parent) {
> +return;

We do need this check when moving, but doesn't having this here break item 
activation?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7268

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7268: Use new libtm API to enable DND reordering within group dialogs.

2017-08-11 Thread Eike Hein 
hein edited the summary of this revision.
hein added a dependency: D7267: Add support for moving group members within a 
group..

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7268

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7268: Use new libtm API to enable DND reordering within group dialogs.

2017-08-11 Thread Eike Hein 
hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  BUG:383405

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7268

AFFECTED FILES
  applets/taskmanager/package/contents/ui/MouseHandler.qml

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas