D7857: Change default argument of grabXKeyboard to XCB_WINDOW_NONE
This revision was automatically updated to reflect the committed changes. Closed by commit R108:a264c2b5cf14: Change default argument of grabXKeyboard to XCB_WINDOW_NONE (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7857?vs=19600=19916#toc REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7857?vs=19600=19916 REVISION DETAIL https://phabricator.kde.org/D7857 AFFECTED FILES utils.h To: graesslin, #kwin, #plasma, broulik Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7857: Change default argument of grabXKeyboard to XCB_WINDOW_NONE
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH grab-x-keyboard-none-window REVISION DETAIL https://phabricator.kde.org/D7857 To: graesslin, #kwin, #plasma, broulik Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7857: Change default argument of grabXKeyboard to XCB_WINDOW_NONE
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The implementation of grabXKeyboard checks whether the passed in arg is XCB_WINDOW_NONE and sets the arg to rootWindow. Thus we don't need to have rootWindow as the default argument, but can have none as the default arg. TEST PLAN Compiles, test which uses the default arg still passes REPOSITORY R108 KWin BRANCH grab-x-keyboard-none-window REVISION DETAIL https://phabricator.kde.org/D7857 AFFECTED FILES utils.h To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
