D7877: Don't recreate kwayland blurmanager on screen size changes
This revision was automatically updated to reflect the committed changes. Closed by commit R108:b3020d6f5a96: Don't recreate kwayland blurmanager on screen size changes (authored by davidedmundson). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7877?vs=19669&id=20089 REVISION DETAIL https://phabricator.kde.org/D7877 AFFECTED FILES effects/blur/blur.cpp effects/blur/blur.h To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7877: Don't recreate kwayland blurmanager on screen size changes
graesslin accepted this revision.
graesslin added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> blur.cpp:94
> +
> +void BlurEffect::updateTexture() {
> +delete target;
nitpick: position of {
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7877
To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff,
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7877: Don't recreate kwayland blurmanager on screen size changes
davidedmundson edited the summary of this revision. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7877 To: davidedmundson, #plasma Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7877: Don't recreate kwayland blurmanager on screen size changes
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY Instead of calling reconfigure() on screen size changes, which deletes and recreates the effect, we can just update the one texture that's mapped to the screen size. --- From the wayland commit. > What surprises me is that BlurManager recreates for Output changes. > That sounds like a bug in KWin (or an area which could be improved). I had thought the same and wrote this (though wanted to have kwayland first) TEST PLAN Logged in and out (my screen resizes on startup due to scaling) Tested on my X machine by turning a screen off. Nothing broke, plasma panels looked the same. Note: Eike tried this patch last week and claimed kwin still crashed. We don't have a backtrace so it could have been something unrelated, applied wrong or that he was deliberately lying to wind me up. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7877 AFFECTED FILES effects/blur/blur.cpp effects/blur/blur.h To: davidedmundson, #plasma Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
