D7891: expose the colorset for the stylesheet

2017-09-29 Thread Marco Martin 
mart added a comment.


  https://phabricator.kde.org/D8060 solves the same problem without new 
dependencies

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D7891

To: mart, #frameworks, #plasma, hein, dfaure
Cc: rikmills, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7891: expose the colorset for the stylesheet

2017-09-29 Thread Rik Mills 
rikmills added a comment.


  Since this change, polkit-kde-agent-1 fails to build from source with the 
error:
  
  >   In file included from /usr/include/KF5/KIconThemes/KIconLoader:1:0,
  >   from 
/<>/polkit-kde-agent-1-5.10.95+p17.10+git20170929.1419/AuthDialog.cpp:37:
  >   /usr/include/KF5/KIconThemes/kiconloader.h:31:10: fatal error: 
kcolorscheme.h: No such file or directory
  >   #include 
  >   ^~~~
  >   compilation terminated.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D7891

To: mart, #frameworks, #plasma, hein, dfaure
Cc: rikmills, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7891: expose the colorset for the stylesheet

2017-09-29 Thread Marco Martin 
mart added inline comments.

INLINE COMMENTS

> dfaure wrote in kiconloader.h:465
> I guess this is OK as is, so remove the comment (it's not we can change this 
> later)

apparently this is giving problems indeed, polkit is now failing to build since 
it wasn't explicitly linking to KConfigWidgets, so may be necessary to 
duplicate the enum

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D7891

To: mart, #frameworks, #plasma, hein, dfaure
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7891: expose the colorset for the stylesheet

2017-09-26 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R302:b06e2ecb32a1: expose the colorset for the stylesheet 
(authored by mart).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7891?vs=19935=19936

REVISION DETAIL
  https://phabricator.kde.org/D7891

AFFECTED FILES
  src/CMakeLists.txt
  src/kiconloader.cpp
  src/kiconloader.h

To: mart, #frameworks, #plasma, hein, dfaure
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7891: expose the colorset for the stylesheet

2017-09-26 Thread Marco Martin 
mart updated this revision to Diff 19935.
mart added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.


  - remove comment

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7891?vs=19787=19935

BRANCH
  arcpatch-D7891

REVISION DETAIL
  https://phabricator.kde.org/D7891

AFFECTED FILES
  src/CMakeLists.txt
  src/kiconloader.cpp
  src/kiconloader.h

To: mart, #frameworks, #plasma, hein, dfaure
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart