D7897: Move X11 specific Workspace initialization code into dedicated method

2017-09-30 Thread Martin Flöser 
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:5cbd28f9a0d4: Move X11 specific Workspace initialization 
code into dedicated method (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7897?vs=19710=20140

REVISION DETAIL
  https://phabricator.kde.org/D7897

AFFECTED FILES
  main.cpp
  workspace.cpp
  workspace.h

To: graesslin, #kwin, #plasma, broulik
Cc: broulik, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7897: Move X11 specific Workspace initialization code into dedicated method

2017-09-25 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  workspace-init-x11

REVISION DETAIL
  https://phabricator.kde.org/D7897

To: graesslin, #kwin, #plasma, broulik
Cc: broulik, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7897: Move X11 specific Workspace initialization code into dedicated method

2017-09-21 Thread Martin Flöser 
graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in workspace.cpp:381
> `kwinApp()->x11Connection()`?

Yes, in a future change :-) Currently this only moves code around and tries to 
not change too much.

Some time in the near to distant future connection() will have to die as well 
as rootWindow(), but that will be one big global search and replace commit.

> broulik wrote in workspace.cpp:397
> Now superfluous, also below

No, I added this TODO, it's not superfluous. This code is still called on 
Wayland if you use XWayland. The TODO says this should only be done in 
kwin_x11, but not in kwin_wayland.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7897

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7897: Move X11 specific Workspace initialization code into dedicated method

2017-09-20 Thread Martin Flöser 
graesslin added a dependency: D7856: Make xstacking order dirty handling work 
without X11.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7897

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart