D7957: Turn on frames around dock widgets by default

2017-10-30 Thread Jens Reuterberg 
jensreuterberg added a comment.


  I would avoid the shadows personally - it would be better to focus on better 
spacing between the two areas and a clearer font usage to define them. Like 
Broulik mentions it was removed more or less by active choice

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: jensreuterberg, abetts, broulik, emmanuelp, elvisangelaccio, nicolasfella, 
markg, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, sebas, 
apol, mart

D7957: Turn on frames around dock widgets by default

2017-10-29 Thread Andres Betts 
abetts added a comment.


  In https://phabricator.kde.org/D7957#161647, @ngraham wrote:
  
  > The shadow seems a bit gratuitous to me, but I have to say I do like the 
extra borders and the nice explicit separator between Panels.
  
  
  Maybe another idea, instead of shadows is changing the colors between those 
containers. After all the bottom portion is a list like the one on the right. 
The background could be whiter.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: abetts, broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D7957: Turn on frames around dock widgets by default

2017-10-29 Thread Nathaniel Graham 
ngraham added a comment.


  The shadow seems a bit gratuitous to me, but I have to say I do like the 
extra borders and the nice explicit separator between Panels.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: abetts, broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D7957: Turn on frames around dock widgets by default

2017-10-29 Thread Andres Betts 
abetts added a comment.


  I would even go as far as doing this:
  
  F5457461: Shadows.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: abetts, broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D7957: Turn on frames around dock widgets by default

2017-10-29 Thread Nathaniel Graham 
ngraham abandoned this revision.
ngraham added a comment.


  Too hard, can't figure it out. Maybe I'll revisit this at another time.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

2017-10-06 Thread Nathaniel Graham 
ngraham planned changes to this revision.
ngraham added a comment.


  I'll see if I can re-work the patch to add separators when frames are off, 
rather than turning on all frames by default.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

2017-09-23 Thread Nathaniel Graham 
ngraham added a comment.


  As a 24 year Mac refugee, I agree with you that Finder's Tags implementation 
is excellent, and I think we should copy it. But the macOS Finder approach 
(everything scrollable in the same sidebar) is what was rejected in 
https://phabricator.kde.org/D7700. But getting there by putting all the Panels 
inside a scrollview with titles always visible is an idea I would fully support.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

2017-09-23 Thread Mark Gaiser 
markg added a comment.


  Watch this: https://www.youtube.com/watch?v=T0Jj4lUm_p8
  Apple really has done a marvelous job in making tags useful!
  
  Anyhow, we can learn a couple things from there implementation of the sidebar.
  
  1. It doesn't scroll "per panel", it scrolls for the whole sidebar! I'd 
suggest implementing that for Dolphin as well.
  2. Because of point 1, there is no need to display a separator because, well, 
everything is visible.
  3. Every "panel" has a visible title (like places has now).
  
  To elaborate some more on point 1. Yes, that will pose an issue with people 
adding in a folder tree and opening a folder with a _lot_ of sub folders. That 
means a lot of scrolling in the panel.
  I don't think that is really much of an issue.. But even if it is, a panel 
can still choose to have a max height and show a scrollbar if it exceeds it's 
limits.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

2017-09-23 Thread Nathaniel Graham 
ngraham added a comment.


  As I am pointing out, without frames the splitter is invisible, which is a 
clear usability issue. It also presents an aesthetic issue since when content 
on either side of the splitter is cut off, it looks like a visual glitch:
  
  F3923285: Cut off for no clear reason.png 

  
  I can't support a change to Dolphin's default layout that has two adjacent 
panels without sorting out the invisible separator issue. If this isn't the 
right way to do it, then so be it, but we will need to resolve it.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

2017-09-23 Thread Mark Gaiser 
markg added a comment.


  -1 for the current version as well.
  We've had those frames before. The benefit of locking docks is no frame (for 
me that is the benefit).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

2017-09-23 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

2017-09-23 Thread Nathaniel Graham 
ngraham edited the test plan for this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

2017-09-23 Thread Nathaniel Graham 
ngraham updated this revision to Diff 19839.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7957?vs=19836=19839

REVISION DETAIL
  https://phabricator.kde.org/D7957

AFFECTED FILES
  kstyle/breeze.kcfg

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

2017-09-23 Thread Nathaniel Graham 
ngraham retitled this revision from "Turn on frames around dock widgets and 
side panels by default" to "Turn on frames around dock widgets by default".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart