D7958: Drop ENABLE_TRANSIENCY_CHECK related code as it doesn't compile

2017-09-24 Thread Martin Flöser 
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:e6ca32131733: Drop ENABLE_TRANSIENCY_CHECK related code 
as it doesnt compile (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7958?vs=19838=19848

REVISION DETAIL
  https://phabricator.kde.org/D7958

AFFECTED FILES
  client.cpp
  group.cpp
  utils.h
  workspace.cpp

To: graesslin, #kwin, #plasma, apol
Cc: apol, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, mart

D7958: Drop ENABLE_TRANSIENCY_CHECK related code as it doesn't compile

2017-09-23 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  I don't really see how this needs review. :)

REPOSITORY
  R108 KWin

BRANCH
  drop-enable-transiency-check

REVISION DETAIL
  https://phabricator.kde.org/D7958

To: graesslin, #kwin, #plasma, apol
Cc: apol, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, mart

D7958: Drop ENABLE_TRANSIENCY_CHECK related code as it doesn't compile

2017-09-23 Thread Martin Flöser 
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  The code ifdefed by ENABLE_TRANSIENCY_CHECK does no longer compile and
  has not compiled since the switch to Qt 5 and KF5 as it still uses
  kDebug and (worse) kDBacktrace. There are several other changes which
  broke the code and I failed trying to get it to compile again. It's a
  classic example of bitrot happening to code which is never getting
  compiled.
  
  As this has not been in a state which could compile for at least several
  years, I think it's best to completely remove it.

REPOSITORY
  R108 KWin

BRANCH
  drop-enable-transiency-check

REVISION DETAIL
  https://phabricator.kde.org/D7958

AFFECTED FILES
  client.cpp
  group.cpp
  utils.h
  workspace.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart