D8012: Only assert on broken GL when we're rendering using GL

2017-09-27 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> graesslin wrote in desktopview.cpp:60
> Is it correct to compare to software? What if vulkan get's introduced?

Then we change it..

The reason it's done this way round is currently is that 
setSceneGraph("aaerkwlakrjaldkfj") will result in it being GL.

They seem to be migrating to using enums, which will make life better in the 
future.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8012

To: davidedmundson, #plasma, broulik
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8012: Only assert on broken GL when we're rendering using GL

2017-09-27 Thread Martin Flöser 
graesslin added inline comments.

INLINE COMMENTS

> desktopview.cpp:60
>  
> -connect(this, &DesktopView::sceneGraphInitialized, this,
> -[this, corona]() {
> -// check whether the GL Context supports OpenGL
> -// Note: hasOpenGLShaderPrograms is broken, see QTBUG--39730
> -if 
> (!QOpenGLShaderProgram::hasOpenGLShaderPrograms(openglContext())) {
> -qWarning() << "GLSL not available, Plasma won't be 
> functional";
> -QMetaObject::invokeMethod(corona, 
> "showOpenGLNotCompatibleWarning", Qt::QueuedConnection);
> -}
> -}, Qt::DirectConnection);
> +if (QQuickWindow::sceneGraphBackend() != QLatin1String("software")) {
> +connect(this, &DesktopView::sceneGraphInitialized, this,

Is it correct to compare to software? What if vulkan get's introduced?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8012

To: davidedmundson, #plasma, broulik
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8012: Only assert on broken GL when we're rendering using GL

2017-09-27 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3eb76ed6c126: Only assert on broken GL when we're 
rendering using GL (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8012?vs=19986&id=19989

REVISION DETAIL
  https://phabricator.kde.org/D8012

AFFECTED FILES
  shell/desktopview.cpp

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8012: Only assert on broken GL when we're rendering using GL

2017-09-27 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8012

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8012: Only assert on broken GL when we're rendering using GL

2017-09-27 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  set backend. Didn't get an error message

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8012

AFFECTED FILES
  shell/desktopview.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart