D8040: Load QtQuick settings
This revision was automatically updated to reflect the committed changes. Closed by commit R108:e7b183f886fb: Load QtQuick settings (authored by davidedmundson). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8040?vs=20051=21708 REVISION DETAIL https://phabricator.kde.org/D8040 AFFECTED FILES CMakeLists.txt main_wayland.cpp main_x11.cpp To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8040: Load QtQuick settings
graesslin added a comment. In https://phabricator.kde.org/D8040#150577, @davidedmundson wrote > If you do want to set this based on the initial scene backend, skip using this method and call the static method on QQuickWindow instead. After reading through the docs I think the combination of both is fine: We can use the QtQuickSettings to have a base. But if we init a QPainter compositor we just enforce software through the QQuickWindow API. That should (TM) work as well. Dynamic switching is then not required. AFAIK the only "dangerous" combination would be QPainter compositor and OpenGL compositing. The other 3 combinations should just work fine. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D8040 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8040: Load QtQuick settings
davidedmundson added a comment. > Let's assume we use XRender or QPainter compositor: how can we switch to software in this case? In KWin that is before we load any QtQuick (at least on Wayland on X11 I'm not sure, Aurorae might be loaded before). Unlike scene we can't switch this at runtime; which means whatever we do we have to support all 4 combinations of GL/Software views into -> GL/Software views. If you do want to set this based on the initial scene backend, skip using this method and call the static method on QQuickWindow instead. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D8040 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8040: Load QtQuick settings
davidedmundson edited the summary of this revision. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D8040 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8040: Load QtQuick settings
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Let's assume we use XRender or QPainter compositor: how can we switch to software in this case? In KWin that is before we load any QtQuick (at least on Wayland on X11 I'm not sure, Aurorae might be loaded before). REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D8040 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8040: Load QtQuick settings
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY Loads settings on whether QtQuick uses Aurorae needed a fix. The rest "just works" with up-to-date plasma framework. TEST PLAN Alt tabbed Showed an OSD Grepped kwin's QML for any custom shaders. (which is the only part that doesn't work here) REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D8040 AFFECTED FILES CMakeLists.txt main_wayland.cpp main_x11.cpp To: davidedmundson, #plasma Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
