D8109: remove bogus test

2017-10-02 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2b67d213871f: remove bogus test (authored by mart).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8109?vs=20241=20243

REVISION DETAIL
  https://phabricator.kde.org/D8109

AFFECTED FILES
  kcms/keyboard/tests/flags_test.cpp

To: mart, #plasma, sebas
Cc: bshah, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8109: remove bogus test

2017-10-02 Thread Bhushan Shah 
bshah added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

BRANCH
  xkbtest

REVISION DETAIL
  https://phabricator.kde.org/D8109

To: mart, #plasma, sebas
Cc: bshah, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8109: remove bogus test

2017-10-02 Thread Sebastian Kügler 
sebas accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  xkbtest

REVISION DETAIL
  https://phabricator.kde.org/D8109

To: mart, #plasma, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8109: remove bogus test

2017-10-02 Thread Marco Martin 
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  the names in /usr/share/X11/xkb/symbols/us are not stable,
  the us keyboard name recently switched from
  "English (US, international with dead keys)"
  to "English (US, intl., with dead keys)"
  breaking the tests,
  so there is no point to test for these names on our side

TEST PLAN
  tests now pass

REPOSITORY
  R119 Plasma Desktop

BRANCH
  xkbtest

REVISION DETAIL
  https://phabricator.kde.org/D8109

AFFECTED FILES
  kcms/keyboard/tests/flags_test.cpp

To: mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8109: remove bogus test

2017-10-02 Thread Marco Martin 
mart added a reviewer: Plasma.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8109

To: mart, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart