D8145: Update pointer position whenever a window gets (un)minimized

2017-10-15 Thread Martin Flöser 
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:1b01f1b30094: Update pointer position whenever a window 
gets (un)minimized (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8145?vs=20356=20795

REVISION DETAIL
  https://phabricator.kde.org/D8145

AFFECTED FILES
  pointer_input.cpp
  workspace.cpp
  workspace.h

To: graesslin, #kwin, #plasma, davidedmundson
Cc: luebking, davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8145: Update pointer position whenever a window gets (un)minimized

2017-10-08 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  minimize-update-pointer-5.11

REVISION DETAIL
  https://phabricator.kde.org/D8145

To: graesslin, #kwin, #plasma, davidedmundson
Cc: luebking, davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8145: Update pointer position whenever a window gets (un)minimized

2017-10-06 Thread Martin Flöser 
graesslin added a comment.


  yep, I actually checked whether we can use the stacking order changed for 
that, but it's clearly documented as only when the actual layering changes. And 
I fear it would cause problems in other areas where code reacts on stacking 
order changes and gets confused if nothing changes.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8145

To: graesslin, #kwin, #plasma
Cc: luebking, davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8145: Update pointer position whenever a window gets (un)minimized

2017-10-05 Thread Thomas Lübking 
luebking added a comment.


  Why should it? The stack remains the same, just one window changes its 
visibility.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8145

To: graesslin, #kwin, #plasma
Cc: luebking, davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8145: Update pointer position whenever a window gets (un)minimized

2017-10-05 Thread David Edmundson 
davidedmundson added a comment.


  Why isn't the stacking order changing when you minimise the first? Shouldn't 
it?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8145

To: graesslin, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8145: Update pointer position whenever a window gets (un)minimized

2017-10-04 Thread Martin Flöser 
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  This fixes the following problem:
  
  1. Have two windows maximized
  2. Click minimize button on first window
  3. Click minimize button on second window
  
  What happened:
  Second click was ignored as the pointer was not updated.
  
  BUG: 378704
  FIXED-IN: 5.11

TEST PLAN
  Nested KWin/Wayland, added two maximized windows, minimized
  both without moving the mouse

REPOSITORY
  R108 KWin

BRANCH
  minimize-update-pointer-5.11

REVISION DETAIL
  https://phabricator.kde.org/D8145

AFFECTED FILES
  pointer_input.cpp
  workspace.cpp
  workspace.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart